YueMi-Development/cloudflare-php
3
0
Fork 0
Code Issues Pull Requests Releases Activity

Removed more object casting

Browse Source
This commit is contained in:
Darin Randal
2018-04-12 23:19:09 -04:00
parent cca073c809
commit c06fe79ad0
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Configurations/PageRulesActions.php
View File

@@ -301,19 +301,9 @@ class PageRulesActions implements Configurations
private function addConfigurationOption(string $setting, array $configuration) private function addConfigurationOption(string $setting, array $configuration)
{ {
/**
* Transforms an, optionally nested, array in to a collection of
* stdClass objects.
*
* @var array $array
*/
$getArrayAsObject = function (array $array) {
return json_decode(json_encode($array));
};
$configuration['id'] = $setting; $configuration['id'] = $setting;
array_push($this->configs, $getArrayAsObject($configuration)); array_push($this->configs, $configuration);
} }
private function getBoolAsOnOrOff(bool $value): string private function getBoolAsOnOrOff(bool $value): string

6
tests/Configurations/PageRulesActionTest.php
View File

@@ -14,8 +14,8 @@ class PageRulesActionTest extends TestCase
$configuration = $actions->getArray(); $configuration = $actions->getArray();
$this->assertCount(1, $configuration); $this->assertCount(1, $configuration);
$this->assertEquals($identifier, $configuration[0]->id); $this->assertEquals($identifier, $configuration[0]['id']);
$this->assertEquals($statusCode, $configuration[0]->value->status_code); $this->assertEquals($statusCode, $configuration[0]['value']['status_code']);
$this->assertEquals($forwardingURL, $configuration[0]->value->url); $this->assertEquals($forwardingURL, $configuration[0]['value']['url']);
} }
} }