From c06fe79ad01d7a009fa53e135ee02740d364ce60 Mon Sep 17 00:00:00 2001 From: Darin Randal Date: Thu, 12 Apr 2018 23:19:09 -0400 Subject: [PATCH] Removed more object casting --- src/Configurations/PageRulesActions.php | 12 +----------- tests/Configurations/PageRulesActionTest.php | 6 +++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/Configurations/PageRulesActions.php b/src/Configurations/PageRulesActions.php index 6f99ee2..58f26f4 100644 --- a/src/Configurations/PageRulesActions.php +++ b/src/Configurations/PageRulesActions.php @@ -301,19 +301,9 @@ class PageRulesActions implements Configurations private function addConfigurationOption(string $setting, array $configuration) { - /** - * Transforms an, optionally nested, array in to a collection of - * stdClass objects. - * - * @var array $array - */ - $getArrayAsObject = function (array $array) { - return json_decode(json_encode($array)); - }; - $configuration['id'] = $setting; - array_push($this->configs, $getArrayAsObject($configuration)); + array_push($this->configs, $configuration); } private function getBoolAsOnOrOff(bool $value): string diff --git a/tests/Configurations/PageRulesActionTest.php b/tests/Configurations/PageRulesActionTest.php index 88d4b91..cc0f871 100644 --- a/tests/Configurations/PageRulesActionTest.php +++ b/tests/Configurations/PageRulesActionTest.php @@ -14,8 +14,8 @@ class PageRulesActionTest extends TestCase $configuration = $actions->getArray(); $this->assertCount(1, $configuration); - $this->assertEquals($identifier, $configuration[0]->id); - $this->assertEquals($statusCode, $configuration[0]->value->status_code); - $this->assertEquals($forwardingURL, $configuration[0]->value->url); + $this->assertEquals($identifier, $configuration[0]['id']); + $this->assertEquals($statusCode, $configuration[0]['value']['status_code']); + $this->assertEquals($forwardingURL, $configuration[0]['value']['url']); } }