Improved enchantment arg parser

build.gradle.kts

@@ -97,6 +97,9 @@ allprojects {
 
         // HuskPlugins
         maven("https://repo.william278.net/releases")
+
+        // FancyHolograms
+        maven("https://repo.fancyplugins.de/releases")
     }
 
     dependencies {

eco-api/src/main/java/com/willfp/eco/core/EcoPlugin.java

@@ -1,5 +1,6 @@
 package com.willfp.eco.core;
 
+import com.google.common.collect.ImmutableList;
 import com.willfp.eco.core.command.impl.PluginCommand;
 import com.willfp.eco.core.config.base.ConfigYml;
 import com.willfp.eco.core.config.base.LangYml;
@@ -36,6 +37,8 @@ import org.jetbrains.annotations.Nullable;
 import java.io.File;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
@@ -120,9 +123,17 @@ public abstract class EcoPlugin extends JavaPlugin implements PluginLike, Regist
 
     /**
      * The display module for the plugin.
+     *
+     * @deprecated Plugins can now have multiple display modules.
      */
+    @Deprecated(since = "6.72.0")
     private DisplayModule displayModule;
 
+    /**
+     * The display modules for the plugin.
+     */
+    private List<DisplayModule> displayModules = new ArrayList<>();
+
     /**
      * The logger for the plugin.
      */
@@ -555,10 +566,15 @@ public abstract class EcoPlugin extends JavaPlugin implements PluginLike, Regist
      * Default code to be executed after the server is up.
      */
     public final void afterLoad() {
-        this.displayModule = createDisplayModule();
+        DisplayModule module = createDisplayModule();
+        if (module != null) {
+            Display.registerDisplayModule(module);
+            this.displayModules.add(module);
+        }
 
-        if (this.getDisplayModule() != null) {
-            Display.registerDisplayModule(this.getDisplayModule());
+        for (DisplayModule displayModule : this.loadDisplayModules()) {
+            Display.registerDisplayModule(displayModule);
+            this.displayModules.add(displayModule);
         }
 
         if (Prerequisite.HAS_PROTOCOLLIB.isMet()) {
@@ -899,14 +915,25 @@ public abstract class EcoPlugin extends JavaPlugin implements PluginLike, Regist
      * Create the display module for the plugin.
      *
      * @return The display module, or null.
+     * @deprecated Use {@link #loadDisplayModules()} instead.
      */
     @Nullable
+    @Deprecated(since = "6.72.0")
     protected DisplayModule createDisplayModule() {
         Validate.isTrue(this.getDisplayModule() == null, "Display module exists!");
 
         return null;
     }
 
+    /**
+     * Load display modules.
+     *
+     * @return The display modules.
+     */
+    protected List<DisplayModule> loadDisplayModules() {
+        return new ArrayList<>();
+    }
+
     /**
      * Get the minimum version of eco to use the plugin.
      *
@@ -1156,12 +1183,23 @@ public abstract class EcoPlugin extends JavaPlugin implements PluginLike, Regist
      * Get the plugin's display module.
      *
      * @return The display module.
+     * @deprecated Use {@link #getDisplayModules()} instead.
      */
     @Nullable
+    @Deprecated(since = "6.72.0", forRemoval = true)
     public DisplayModule getDisplayModule() {
         return this.displayModule;
     }
 
+    /**
+     * Get the plugin's display modules.
+     *
+     * @return The display modules.
+     */
+    public List<DisplayModule> getDisplayModules() {
+        return ImmutableList.copyOf(this.displayModules);
+    }
+
     /**
      * Get if the plugin is outdated.
      *

eco-api/src/main/java/com/willfp/eco/core/display/Display.java

@@ -211,12 +211,22 @@ public final class Display {
                 new ArrayList<>()
         );
 
-        modules.removeIf(it -> it.getPluginName().equalsIgnoreCase(module.getPluginName()));
         modules.add(module);
 
         REGISTERED_MODULES.put(module.getWeight(), modules);
     }
 
+    /**
+     * Unregister a display module.
+     *
+     * @param module The module.
+     */
+    public static void unregisterDisplayModule(@NotNull final DisplayModule module) {
+        for (List<DisplayModule> modules : REGISTERED_MODULES.values()) {
+            modules.remove(module);
+        }
+    }
+
     private Display() {
         throw new UnsupportedOperationException("This is a utility class and cannot be instantiated");
     }

eco-api/src/main/java/com/willfp/eco/core/items/Items.java

@@ -6,6 +6,7 @@ import com.willfp.eco.core.Eco;
 import com.willfp.eco.core.fast.FastItemStack;
 import com.willfp.eco.core.items.args.LookupArgParser;
 import com.willfp.eco.core.items.provider.ItemProvider;
+import com.willfp.eco.core.items.tag.ItemTag;
 import com.willfp.eco.core.recipe.parts.EmptyTestableItem;
 import com.willfp.eco.core.recipe.parts.MaterialTestableItem;
 import com.willfp.eco.core.recipe.parts.ModifiedTestableItem;
@@ -13,7 +14,6 @@ import com.willfp.eco.core.recipe.parts.TestableStack;
 import com.willfp.eco.core.recipe.parts.UnrestrictedMaterialTestableItem;
 import com.willfp.eco.util.NamespacedKeyUtils;
 import com.willfp.eco.util.NumberUtils;
-import kotlin.Suppress;
 import org.bukkit.Material;
 import org.bukkit.NamespacedKey;
 import org.bukkit.enchantments.Enchantment;
@@ -93,6 +93,11 @@ public final class Items {
      */
     private static final Map<String, Material> FRIENDLY_MATERIAL_NAMES = new HashMap<>();
 
+    /**
+     * All tags.
+     */
+    private static final Map<String, ItemTag> TAGS = new HashMap<>();
+
     /**
      * Register a new custom item.
      *
@@ -217,7 +222,20 @@ public final class Items {
 
         String[] split = args[0].toLowerCase().split(":");
 
-        if (split.length == 1) {
+        String base = split[0];
+        boolean isTag = base.startsWith("#");
+
+        if (isTag) {
+            String tag = base.substring(1);
+            ItemTag itemTag = TAGS.get(tag);
+
+            if (itemTag == null) {
+                return new EmptyTestableItem();
+            }
+            item = itemTag.toTestableItem();
+        }
+
+        if (split.length == 1 && !isTag) {
             String itemType = args[0];
             boolean isWildcard = itemType.startsWith("*");
             if (isWildcard) {
@@ -230,7 +248,7 @@ public final class Items {
             item = isWildcard ? new UnrestrictedMaterialTestableItem(material) : new MaterialTestableItem(material);
         }
 
-        if (split.length == 2) {
+        if (split.length == 2 && !isTag) {
             String namespace = split[0];
             String keyID = split[1];
             NamespacedKey namespacedKey = NamespacedKeyUtils.create(namespace, keyID);
@@ -274,7 +292,7 @@ public final class Items {
         Legacy namespace:id:amount format
         This has been superseded by namespace:id amount
          */
-        if (split.length == 3) {
+        if (split.length == 3 && !isTag) {
             TestableItem part = REGISTRY.get(NamespacedKeyUtils.create(split[0], split[1]));
             if (part == null) {
                 return new EmptyTestableItem();
@@ -306,7 +324,8 @@ public final class Items {
 
         List<Predicate<ItemStack>> predicates = new ArrayList<>();
 
-        for (LookupArgParser argParser : ARG_PARSERS) {
+        for (
+                LookupArgParser argParser : ARG_PARSERS) {
             Predicate<ItemStack> predicate = argParser.parseArguments(modifierArgs, meta);
             if (predicate != null) {
                 predicates.add(argParser.parseArguments(modifierArgs, meta));
@@ -611,6 +630,15 @@ public final class Items {
         return false;
     }
 
+    /**
+     * Register a new item tag.
+     *
+     * @param tag The tag.
+     */
+    public static void registerTag(@NotNull final ItemTag tag) {
+        TAGS.put(tag.getIdentifier(), tag);
+    }
+
     private Items() {
         throw new UnsupportedOperationException("This is a utility class and cannot be instantiated");
     }

eco-api/src/main/java/com/willfp/eco/core/items/tag/CustomItemTag.java

@@ -0,0 +1,29 @@
+package com.willfp.eco.core.items.tag;
+
+import org.bukkit.NamespacedKey;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * A custom item tag.
+ */
+public abstract class CustomItemTag implements ItemTag {
+    /**
+     * The key.
+     */
+    private final NamespacedKey key;
+
+    /**
+     * Create a new custom item tag.
+     *
+     * @param key         The key.
+     */
+    public CustomItemTag(@NotNull final NamespacedKey key) {
+        this.key = key;
+    }
+
+    @Override
+    @NotNull
+    public String getIdentifier() {
+        return key.toString();
+    }
+}

eco-api/src/main/java/com/willfp/eco/core/items/tag/ItemTag.java

@@ -0,0 +1,66 @@
+package com.willfp.eco.core.items.tag;
+
+import com.willfp.eco.core.items.TestableItem;
+import org.bukkit.Material;
+import org.bukkit.inventory.ItemStack;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * A group of items that share a common trait.
+ */
+public interface ItemTag {
+    /**
+     * Get the identifier of the tag.
+     *
+     * @return The identifier.
+     */
+    @NotNull
+    String getIdentifier();
+
+    /**
+     * Check if an item matches the tag.
+     *
+     * @param itemStack The item to check.
+     * @return If the item matches the tag.
+     */
+    boolean matches(@NotNull ItemStack itemStack);
+
+    /**
+     * Get an example item.
+     *
+     * @return The example item.
+     */
+    @Nullable
+    default ItemStack getExampleItem() {
+        return null;
+    }
+
+    /**
+     * Convert this tag to a testable item.
+     *
+     * @return The testable item.
+     */
+    @NotNull
+    default TestableItem toTestableItem() {
+        return new TestableItem() {
+            @Override
+            public boolean matches(@Nullable final ItemStack itemStack) {
+                return itemStack != null && ItemTag.this.matches(itemStack);
+            }
+
+            @Override
+            public @NotNull ItemStack getItem() {
+                ItemStack example = ItemTag.this.getExampleItem();
+                return example == null ? new ItemStack(Material.STONE) : example;
+            }
+
+            @Override
+            public String toString() {
+                return "ItemTagTestableItem{" +
+                        "tag=" + ItemTag.this.getIdentifier() +
+                        '}';
+            }
+        };
+    }
+}

eco-api/src/main/java/com/willfp/eco/core/items/tag/VanillaItemTag.java

@@ -0,0 +1,49 @@
+package com.willfp.eco.core.items.tag;
+
+import org.bukkit.Material;
+import org.bukkit.Tag;
+import org.bukkit.inventory.ItemStack;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * A vanilla item tag.
+ */
+public final class VanillaItemTag implements ItemTag {
+    /**
+     * The identifier.
+     */
+    private final String identifier;
+
+    /**
+     * The tag.
+     */
+    private final Tag<Material> tag;
+
+    /**
+     * Create a new vanilla item tag.
+     *
+     * @param identifier The identifier.
+     * @param tag        The tag.
+     */
+    public VanillaItemTag(@NotNull final String identifier,
+                          @NotNull final Tag<Material> tag) {
+        this.identifier = identifier;
+        this.tag = tag;
+    }
+
+    @Override
+    @NotNull
+    public String getIdentifier() {
+        return identifier;
+    }
+
+    @Override
+    public boolean matches(@NotNull final ItemStack itemStack) {
+        return tag.isTagged(itemStack.getType());
+    }
+
+    @Override
+    public @NotNull ItemStack getExampleItem() {
+        return new ItemStack(tag.getValues().stream().findFirst().orElse(Material.STONE));
+    }
+}

eco-core/core-backend-modern/src/main/kotlin/com/willfp/eco/internal/compat/modern/recipes/AutocrafterPatchImpl.kt

@@ -0,0 +1,19 @@
+@file:Suppress("UnstableApiUsage")
+
+package com.willfp.eco.internal.compat.modern.recipes
+
+import com.willfp.eco.core.EcoPlugin
+import com.willfp.eco.internal.recipes.AutocrafterPatch
+import org.bukkit.event.EventHandler
+import org.bukkit.event.block.CrafterCraftEvent
+
+class AutocrafterPatchImpl: AutocrafterPatch {
+    @EventHandler
+    fun preventEcoRecipes(event: CrafterCraftEvent) {
+        if (!EcoPlugin.getPluginNames().contains(event.recipe.key.namespace)) {
+            return
+        }
+
+        event.isCancelled = true
+    }
+}

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/items/ArgParserCustomModelData.kt

@@ -7,20 +7,12 @@ import java.util.function.Predicate
 
 object ArgParserCustomModelData : LookupArgParser {
     override fun parseArguments(args: Array<out String>, meta: ItemMeta): Predicate<ItemStack>? {
-        var modelData: Int? = null
+        val arg = args.firstOrNull {
+            it.startsWith("custom-model-data:", ignoreCase = true)
+                    || it.startsWith("custom_model_data:", ignoreCase = true)
+        } ?: return null
 
-        for (arg in args) {
-            val argSplit = arg.split(":")
-            if (!argSplit[0].equals("custom-model-data", ignoreCase = true)) {
-                continue
-            }
-            if (argSplit.size < 2) {
-                continue
-            }
-            modelData = argSplit[1].toIntOrNull()
-        }
-
-        modelData ?: return null
+        val modelData = arg.split(":")[1].toIntOrNull() ?: return null
 
         meta.setCustomModelData(modelData)
 
@@ -40,6 +32,6 @@ object ArgParserCustomModelData : LookupArgParser {
             return null
         }
 
-        return "custom-model-data:${meta.customModelData}"
+        return "custom_model_data:${meta.customModelData}"
     }
 }

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/items/ArgParserEnchantment.kt

@@ -2,7 +2,7 @@ package com.willfp.eco.internal.items
 
 import com.willfp.eco.core.fast.fast
 import com.willfp.eco.core.items.args.LookupArgParser
-import com.willfp.eco.util.NamespacedKeyUtils
+import org.bukkit.NamespacedKey
 import org.bukkit.enchantments.Enchantment
 import org.bukkit.inventory.ItemStack
 import org.bukkit.inventory.meta.EnchantmentStorageMeta
@@ -16,17 +16,10 @@ object ArgParserEnchantment : LookupArgParser {
         for (arg in args) {
             val argSplit = arg.split(":")
 
-            if (argSplit.size < 2) {
-                continue
-            }
+            val enchant = Enchantment.getByKey(NamespacedKey.minecraft(argSplit[0])) ?: continue
+            val level = argSplit.getOrNull(1)?.toIntOrNull() ?: enchant.maxLevel
 
-            @Suppress("DEPRECATION")
-            val enchant = Enchantment.getByKey(NamespacedKeyUtils.create("minecraft", argSplit[0]))
-            val level = argSplit[1].toIntOrNull()
-
-            if (enchant != null && level != null) {
-                enchants[enchant] = level
-            }
+            enchants[enchant] = level
         }
 
         if (enchants.isEmpty()) {

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/items/tags/VanillaItemTags.kt

@@ -0,0 +1,39 @@
+package com.willfp.eco.internal.items.tags
+
+import com.willfp.eco.core.items.Items
+import com.willfp.eco.core.items.tag.VanillaItemTag
+import org.bukkit.Keyed
+import org.bukkit.Material
+import org.bukkit.Tag
+
+object VanillaItemTags {
+    fun register() {
+        // Get all tags
+        val allTags = Tag::class.java.declaredFields
+            .filter { it.type == Tag::class.java }
+            .mapNotNull {
+                val tag = it.get(null) as? Tag<*>
+                if (tag == null) {
+                    null
+                } else {
+                    NamedTag(it.name.lowercase(), tag)
+                }
+            }
+
+        // Register all tags
+        for (tag in allTags) {
+            if (tag.isMaterial) {
+                Items.registerTag(
+                    @Suppress("UNCHECKED_CAST")
+                    VanillaItemTag(tag.name, tag.tag as Tag<Material>)
+                )
+            }
+        }
+    }
+
+    private data class NamedTag<T : Keyed>(val name: String, val tag: Tag<T>) {
+        // Check if tag is material
+        val isMaterial: Boolean
+            get() = tag.values.firstOrNull() is Material
+    }
+}

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/price/PriceFactoryXP.kt

@@ -8,6 +8,11 @@ import org.bukkit.entity.Player
 import java.util.UUID
 import kotlin.math.roundToInt
 
+private fun getXPNeededForLevel(level: Int): Int {
+    // XP Formula from NMS Player
+    return if (level >= 30) 112 + (level - 30) * 9 else (if (level >= 15) 37 + (level - 15) * 5 else 7 + level * 2)
+}
+
 object PriceFactoryXP : PriceFactory {
     override fun getNames() = listOf(
         "xp",
@@ -25,15 +30,37 @@ object PriceFactoryXP : PriceFactory {
     ) : Price {
         private val multipliers = mutableMapOf<UUID, Double>()
 
-        override fun canAfford(player: Player, multiplier: Double): Boolean =
-            player.totalExperience >= getValue(player, multiplier)
+        override fun canAfford(player: Player, multiplier: Double): Boolean {
+            var totalExperience = 0
+            for (level in 0 until player.level) {
+                totalExperience += getXPNeededForLevel(level)
+            }
+
+            totalExperience += (player.exp * getXPNeededForLevel(player.level)).toInt()
+
+            return totalExperience >= getValue(player, multiplier).roundToInt()
+        }
 
         override fun pay(player: Player, multiplier: Double) {
-            player.totalExperience -= getValue(player, multiplier).roundToInt()
+            takeXP(player, getValue(player, multiplier).roundToInt())
+        }
+
+        private fun takeXP(player: Player, amount: Int) {
+            val currentLevel = player.level
+            val currentExp = player.exp * getXPNeededForLevel(currentLevel)
+
+            if (currentExp >= amount) {
+                player.exp = (currentExp - amount) / getXPNeededForLevel(currentLevel)
+            } else {
+                // Handle recursive level down
+                player.exp = 1f
+                player.level = (currentLevel - 1).coerceAtLeast(0)
+                takeXP(player, (amount - currentExp).toInt())
+            }
         }
 
         override fun giveTo(player: Player, multiplier: Double) {
-            player.totalExperience += getValue(player, multiplier).roundToInt()
+            player.giveExp(getValue(player, multiplier).roundToInt())
         }
 
         override fun getValue(player: Player, multiplier: Double): Double {

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/recipes/AutocrafterPatch.kt

@@ -0,0 +1,7 @@
+package com.willfp.eco.internal.recipes
+
+import com.willfp.eco.internal.compat.ModernCompatibilityProxy
+import org.bukkit.event.Listener
+
+@ModernCompatibilityProxy("recipes.AutocrafterPatchImpl")
+interface AutocrafterPatch: Listener

eco-core/core-nms/v1_21/src/main/kotlin/com/willfp/eco/internal/spigot/proxy/v1_21/DisplayName.kt

@@ -43,15 +43,13 @@ class DisplayName : DisplayNameProxy {
         val nmsComponent = displayName.toNMS()
 
         val nmsEntity = entity.handle
-        nmsEntity.isCustomNameVisible
-        val entityData = SynchedEntityData.Builder(nmsEntity).build()
-
-        entityData.set(displayNameAccessor, Optional.of(nmsComponent), true)
-        entityData.set(customNameVisibleAccessor, visible, true)
 
         val packet = ClientboundSetEntityDataPacket(
             nmsEntity.id,
-            entityData.packDirty() ?: throw IllegalStateException("No packed entity data")
+            listOf(
+                SynchedEntityData.DataValue.create(displayNameAccessor, Optional.of(nmsComponent)),
+                SynchedEntityData.DataValue.create(customNameVisibleAccessor, visible)
+            )
         )
 
         player.sendPacket(Packet(packet))

eco-core/core-plugin/build.gradle.kts

@@ -66,6 +66,7 @@ dependencies {
     compileOnly("net.william278.huskclaims:huskclaims-bukkit:1.0.1")
     compileOnly("net.william278:husktowns:2.6.1")
     compileOnly("com.github.jojodmo:ItemBridge:b0054538c1")
+    compileOnly("de.oliver:FancyHolograms:2.3.0")
 
     compileOnly(fileTree("../../lib") {
         include("*.jar")

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/EcoSpigotPlugin.kt

@@ -17,6 +17,7 @@ import com.willfp.eco.core.integrations.mcmmo.McmmoManager
 import com.willfp.eco.core.integrations.placeholder.PlaceholderManager
 import com.willfp.eco.core.integrations.shop.ShopManager
 import com.willfp.eco.core.items.Items
+import com.willfp.eco.core.items.tag.VanillaItemTag
 import com.willfp.eco.core.packet.PacketListener
 import com.willfp.eco.core.particle.Particles
 import com.willfp.eco.core.price.Prices
@@ -52,12 +53,14 @@ import com.willfp.eco.internal.items.ArgParserName
 import com.willfp.eco.internal.items.ArgParserTexture
 import com.willfp.eco.internal.items.ArgParserUnbreakable
 import com.willfp.eco.internal.items.ModernItemArgParsers
+import com.willfp.eco.internal.items.tags.VanillaItemTags
 import com.willfp.eco.internal.lookup.SegmentParserGroup
 import com.willfp.eco.internal.lookup.SegmentParserUseIfPresent
 import com.willfp.eco.internal.particle.ParticleFactoryRGB
 import com.willfp.eco.internal.price.PriceFactoryEconomy
 import com.willfp.eco.internal.price.PriceFactoryXP
 import com.willfp.eco.internal.price.PriceFactoryXPLevels
+import com.willfp.eco.internal.recipes.AutocrafterPatch
 import com.willfp.eco.internal.spigot.arrows.ArrowDataListener
 import com.willfp.eco.internal.spigot.data.DataListener
 import com.willfp.eco.internal.spigot.data.DataYml
@@ -114,6 +117,7 @@ import com.willfp.eco.internal.spigot.integrations.economy.EconomyVault
 import com.willfp.eco.internal.spigot.integrations.entitylookup.EntityLookupModelEngine
 import com.willfp.eco.internal.spigot.integrations.hologram.HologramCMI
 import com.willfp.eco.internal.spigot.integrations.hologram.HologramDecentHolograms
+import com.willfp.eco.internal.spigot.integrations.hologram.HologramFancyHolograms
 import com.willfp.eco.internal.spigot.integrations.hologram.HologramHolographicDisplays
 import com.willfp.eco.internal.spigot.integrations.mcmmo.McmmoIntegrationImpl
 import com.willfp.eco.internal.spigot.integrations.multiverseinventories.MultiverseInventoriesIntegration
@@ -262,6 +266,9 @@ abstract class EcoSpigotPlugin : EcoPlugin() {
         if (!Prerequisite.HAS_PAPER.isMet) {
             bukkitAudiences = BukkitAudiences.create(this)
         }
+
+        // Init vanilla item tags
+        VanillaItemTags.register()
     }
 
     override fun handleDisable() {
@@ -369,6 +376,7 @@ abstract class EcoSpigotPlugin : EcoPlugin() {
             IntegrationLoader("CMI") { HologramManager.register(HologramCMI()) },
             IntegrationLoader("DecentHolograms") { HologramManager.register(HologramDecentHolograms()) },
             //IntegrationLoader("GHolo") { HologramManager.register(HologramGHolo()) },
+            IntegrationLoader("FancyHolograms") { HologramManager.register(HologramFancyHolograms()) },
 
             // AFK
             IntegrationLoader("Essentials") { AFKManager.register(AFKIntegrationEssentials()) },
@@ -433,6 +441,10 @@ abstract class EcoSpigotPlugin : EcoPlugin() {
             listeners.add(NaturalExpGainListenersSpigot())
         }
 
+        ifModern {
+            listeners += loadProxy<AutocrafterPatch>()
+        }
+
         return listeners
     }
 

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/integrations/hologram/HologramFancyHolograms.kt

@@ -0,0 +1,45 @@
+package com.willfp.eco.internal.spigot.integrations.hologram
+
+import com.willfp.eco.core.integrations.hologram.Hologram
+import com.willfp.eco.core.integrations.hologram.HologramIntegration
+import de.oliver.fancyholograms.api.FancyHologramsPlugin
+import de.oliver.fancyholograms.api.data.TextHologramData
+import org.bukkit.Location
+import java.util.UUID
+import kotlin.jvm.optionals.getOrNull
+
+class HologramFancyHolograms : HologramIntegration {
+    private val manager = FancyHologramsPlugin.get().hologramManager
+
+    override fun createHologram(location: Location, contents: List<String>): Hologram {
+        val id = UUID.randomUUID().toString()
+
+        val data = TextHologramData(id, location)
+        data.text = contents
+        data.isPersistent = false
+
+        val holo = manager.create(data)
+        FancyHologramsPlugin.get().hologramManager.addHologram(holo)
+
+        return HologramImplFancyHolograms(id)
+    }
+
+    override fun getPluginName(): String {
+        return "FancyHolograms"
+    }
+
+    inner class HologramImplFancyHolograms(
+        private val id: String,
+    ) : Hologram {
+        override fun remove() {
+            val hologram = manager.getHologram(id).getOrNull() ?: return
+            manager.removeHologram(hologram)
+        }
+
+        override fun setContents(contents: List<String>) {
+            val hologram = manager.getHologram(id).getOrNull() ?: return
+            val data = hologram.data as? TextHologramData ?: return
+            data.text = contents
+        }
+    }
+}

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/recipes/CraftingRecipeListener.kt

@@ -1,10 +1,8 @@
 package com.willfp.eco.internal.spigot.recipes
 
-import com.willfp.eco.core.Eco
 import com.willfp.eco.core.EcoPlugin
 import com.willfp.eco.core.recipe.Recipes
 import org.bukkit.Keyed
-import org.bukkit.entity.Player
 import org.bukkit.event.EventHandler
 import org.bukkit.event.Listener
 import org.bukkit.event.inventory.CraftItemEvent
@@ -17,6 +15,7 @@ class CraftingRecipeListener(val plugin: EcoPlugin) : Listener {
         if (!EcoPlugin.getPluginNames().contains(event.recipe.namespace)) {
             return
         }
+
         if (event.recipe.key.contains("_displayed")) {
             event.isCancelled = true
         }

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/recipes/CraftingRecipes.kt

@@ -59,4 +59,4 @@ class WrappedCraftItemEvent(
         event.result = Event.Result.DENY
         event.isCancelled = true
     }
-}
+}

eco-core/core-plugin/src/main/resources/plugin.yml

@@ -61,3 +61,4 @@ softdepend:
   - PlayerPoints
   - Denizen
   - RoyaleEconomy
+  - FancyHolograms

gradle.properties

@@ -1,2 +1,2 @@
-version = 6.71.5
+version = 6.73.0
 kotlin.incremental.useClasspathSnapshot=false