More optimisations to EcoConfig

eco-api/src/main/java/com/willfp/eco/core/placeholder/context/MergedInjectableContext.java

@@ -3,10 +3,12 @@ package com.willfp.eco.core.placeholder.context;
 import com.willfp.eco.core.placeholder.InjectablePlaceholder;
 import com.willfp.eco.core.placeholder.PlaceholderInjectable;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Objects;
 import java.util.Set;
 
 /**
@@ -67,4 +69,24 @@ public class MergedInjectableContext implements PlaceholderInjectable {
 
         return injections;
     }
+
+    @Override
+    public boolean equals(@Nullable final Object o) {
+        if (this == o) {
+            return true;
+        }
+
+        if (!(o instanceof MergedInjectableContext that)) {
+            return false;
+        }
+
+        return Objects.equals(baseContext, that.baseContext)
+                && Objects.equals(additionalContext, that.additionalContext)
+                && Objects.equals(extraInjections, that.extraInjections);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(baseContext, additionalContext, extraInjections);
+    }
 }

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/config/EcoConfig.kt

@@ -7,7 +7,6 @@ import com.willfp.eco.core.placeholder.context.PlaceholderContext
 import com.willfp.eco.internal.fast.listView
 import com.willfp.eco.util.StringUtils
 import org.bukkit.configuration.file.YamlConfiguration
-import java.util.Objects
 import java.util.concurrent.ConcurrentHashMap
 
 @Suppress("UNCHECKED_CAST")
@@ -235,22 +234,26 @@ open class EcoConfig(
             return false
         }
 
-        if (configType != other.configType) {
-            return false
-        }
-
-        if (values != other.values) {
-            return false
-        }
-
-        if (injections != other.injections) {
-            return false
-        }
-
-        return true
+        // Hey! Don't care. This works.
+        return this.hashCode() == other.hashCode()
     }
 
     override fun hashCode(): Int {
-        return Objects.hash(values, configType, injections)
+        /*
+        The keys are completely redundant, as they are only used to prevent
+        duplicate keys in the map. Therefore, we can ignore them and just
+        hash the actual placeholder values.
+         */
+
+        var injectionHash = 0
+
+        injections.forEachValue(5) {
+            injectionHash = injectionHash xor (it.hashCode() shl 5)
+        }
+
+        // hashCode() has to compute extremely quickly, so we're using bitwise, because why not?
+        // Fucking filthy to use identityHashCode here, but it should be extremely fast
+        val identityHash = System.identityHashCode(this)
+        return (identityHash shl 5) - (identityHash xor configType.hashCode()) + injectionHash
     }
 }

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/extensions/EcoExtensionLoader.kt

@@ -59,7 +59,7 @@ class EcoExtensionLoader(
         val pluginVersion = Version(extensionYml.getStringOrNull("plugin-version") ?: "0.0.0")
         val pluginName = extensionYml.getStringOrNull("plugin")
 
-        if (pluginName != null && pluginName.equals(this.plugin.description.name, ignoreCase = true)) {
+        if (pluginName != null && !pluginName.equals(this.plugin.description.name, ignoreCase = true)) {
             throw ExtensionLoadException("${extensionJar.name} is only compatible with $pluginName!")
         }
 

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/data/ProfileHandler.kt

@@ -9,7 +9,6 @@ import com.willfp.eco.internal.spigot.EcoSpigotPlugin
 import com.willfp.eco.internal.spigot.ServerLocking
 import com.willfp.eco.internal.spigot.data.storage.DataHandler
 import com.willfp.eco.internal.spigot.data.storage.HandlerType
-import com.willfp.eco.internal.spigot.data.storage.LegacyMySQLDataHandler
 import com.willfp.eco.internal.spigot.data.storage.MongoDataHandler
 import com.willfp.eco.internal.spigot.data.storage.MySQLDataHandler
 import com.willfp.eco.internal.spigot.data.storage.YamlDataHandler
@@ -28,17 +27,6 @@ class ProfileHandler(
         HandlerType.YAML -> YamlDataHandler(plugin, this)
         HandlerType.MYSQL -> MySQLDataHandler(plugin, this)
         HandlerType.MONGO -> MongoDataHandler(plugin, this)
-        HandlerType.LEGACY_MYSQL -> LegacyMySQLDataHandler(plugin, this)
-    }
-
-    init {
-        if (handler.type == HandlerType.LEGACY_MYSQL) {
-            plugin.logger.warning("You're using the legacy MySQL handler!")
-            plugin.logger.warning("Some features will not work and you may get unfixable errors.")
-            plugin.logger.warning("Support cannot be given to data issues related to legacy MySQL.")
-            plugin.logger.warning("Change your data handler to mysql, mongo, or yaml to fix this!")
-            plugin.logger.warning("This can be done in /plugins/eco/config.yml")
-        }
     }
 
     fun accessLoadedProfile(uuid: UUID): EcoProfile? =
@@ -90,11 +78,7 @@ class ProfileHandler(
         }
 
 
-        var previousHandlerType = HandlerType.valueOf(plugin.dataYml.getString("previous-handler"))
-
-        if (previousHandlerType == HandlerType.MYSQL && !plugin.dataYml.has("new-mysql")) {
-            previousHandlerType = HandlerType.LEGACY_MYSQL
-        }
+        val previousHandlerType = HandlerType.valueOf(plugin.dataYml.getString("previous-handler"))
 
         if (previousHandlerType == type) {
             return
@@ -104,7 +88,6 @@ class ProfileHandler(
             HandlerType.YAML -> YamlDataHandler(plugin, this)
             HandlerType.MYSQL -> MySQLDataHandler(plugin, this)
             HandlerType.MONGO -> MongoDataHandler(plugin, this)
-            HandlerType.LEGACY_MYSQL -> LegacyMySQLDataHandler(plugin, this)
         }
 
         ServerLocking.lock("Migrating player data! Check console for more information.")

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/data/storage/HandlerType.kt

@@ -3,6 +3,5 @@ package com.willfp.eco.internal.spigot.data.storage
 enum class HandlerType {
     YAML,
     MYSQL,
-    MONGO,
-    LEGACY_MYSQL
+    MONGO
 }

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/data/storage/LegacyMySQLDataHandler.kt

@@ -1,315 +0,0 @@
-package com.willfp.eco.internal.spigot.data.storage
-
-import com.github.benmanes.caffeine.cache.Caffeine
-import com.google.common.util.concurrent.ThreadFactoryBuilder
-import com.willfp.eco.core.Eco
-import com.willfp.eco.core.EcoPlugin
-import com.willfp.eco.core.data.keys.PersistentDataKey
-import com.willfp.eco.core.data.keys.PersistentDataKeyType
-import com.willfp.eco.internal.spigot.EcoSpigotPlugin
-import com.willfp.eco.internal.spigot.data.ProfileHandler
-import com.willfp.eco.internal.spigot.data.serverProfileUUID
-import com.zaxxer.hikari.HikariConfig
-import com.zaxxer.hikari.HikariDataSource
-import org.jetbrains.exposed.dao.id.UUIDTable
-import org.jetbrains.exposed.sql.BooleanColumnType
-import org.jetbrains.exposed.sql.Column
-import org.jetbrains.exposed.sql.Database
-import org.jetbrains.exposed.sql.DoubleColumnType
-import org.jetbrains.exposed.sql.IntegerColumnType
-import org.jetbrains.exposed.sql.ResultRow
-import org.jetbrains.exposed.sql.SchemaUtils
-import org.jetbrains.exposed.sql.VarCharColumnType
-import org.jetbrains.exposed.sql.insert
-import org.jetbrains.exposed.sql.select
-import org.jetbrains.exposed.sql.transactions.transaction
-import org.jetbrains.exposed.sql.update
-import java.util.UUID
-import java.util.concurrent.Callable
-import java.util.concurrent.Executors
-import java.util.concurrent.TimeUnit
-
-/*
-
-The MySQL data handler is hot garbage for several reasons:
-- Using MySQL on unstructured data: it's being horrifically misused, but that's just how it has to be.
-- Can't remove un-needed keys, there's wasted space in the columns everywhere.
-- No native support for the STRING_LIST type, instead it 'serializes' the lists with semicolons as separators.
-- General lack of flexibility, it's too rigid.
-
-That's why I added the MongoDB handler, it's far, far better suited for what eco does - use it over
-MySQL if you can.
-
-Oh, also - I don't really know how this class works. I've rewritten it and hacked it together several ways
-in several sessions, and it's basically complete gibberish to me. Adding the STRING_LIST type is probably
-the worst bodge I've shipped in production.
-
- */
-
-@Suppress("UNCHECKED_CAST")
-class LegacyMySQLDataHandler(
-    plugin: EcoSpigotPlugin,
-    handler: ProfileHandler
-) : DataHandler(HandlerType.LEGACY_MYSQL) {
-    private val database: Database
-    private val playerHandler: ImplementedMySQLHandler
-    private val serverHandler: ImplementedMySQLHandler
-
-    init {
-        val config = HikariConfig()
-        config.driverClassName = "com.mysql.cj.jdbc.Driver"
-        config.username = plugin.configYml.getString("mysql.user")
-        config.password = plugin.configYml.getString("mysql.password")
-        config.jdbcUrl = "jdbc:mysql://" +
-                "${plugin.configYml.getString("mysql.host")}:" +
-                "${plugin.configYml.getString("mysql.port")}/" +
-                plugin.configYml.getString("mysql.database")
-        config.maximumPoolSize = plugin.configYml.getInt("mysql.connections")
-
-        database = Database.connect(HikariDataSource(config))
-
-        playerHandler = ImplementedMySQLHandler(
-            handler,
-            UUIDTable("eco_players"),
-            plugin
-        )
-
-        serverHandler = ImplementedMySQLHandler(
-            handler,
-            UUIDTable("eco_server"),
-            plugin
-        )
-    }
-
-    override fun <T : Any> read(uuid: UUID, key: PersistentDataKey<T>): T? {
-        return applyFor(uuid) {
-            it.read(uuid, key)
-        }
-    }
-
-    override fun <T : Any> write(uuid: UUID, key: PersistentDataKey<T>, value: T) {
-        applyFor(uuid) {
-            it.write(uuid, key, value)
-        }
-    }
-
-    override fun saveKeysFor(uuid: UUID, keys: Set<PersistentDataKey<*>>) {
-        applyFor(uuid) {
-            it.saveKeysForRow(uuid, keys)
-        }
-    }
-
-    private inline fun <R> applyFor(uuid: UUID, function: (ImplementedMySQLHandler) -> R): R {
-        return if (uuid == serverProfileUUID) {
-            function(serverHandler)
-        } else {
-            function(playerHandler)
-        }
-    }
-
-    override fun initialize() {
-        playerHandler.initialize()
-        serverHandler.initialize()
-    }
-
-    @Suppress("UNCHECKED_CAST")
-    private inner class ImplementedMySQLHandler(
-        private val handler: ProfileHandler,
-        private val table: UUIDTable,
-        private val plugin: EcoPlugin
-    ) {
-        private val rows = Caffeine.newBuilder()
-            .expireAfterWrite(3, TimeUnit.SECONDS)
-            .build<UUID, ResultRow>()
-
-        private val threadFactory = ThreadFactoryBuilder().setNameFormat("eco-legacy-mysql-thread-%d").build()
-        private val executor = Executors.newFixedThreadPool(plugin.configYml.getInt("mysql.threads"), threadFactory)
-        val registeredKeys = mutableSetOf<PersistentDataKey<*>>()
-
-        init {
-            transaction(database) {
-                SchemaUtils.create(table)
-            }
-        }
-
-        fun initialize() {
-            transaction(database) {
-                SchemaUtils.createMissingTablesAndColumns(table, withLogs = false)
-            }
-        }
-
-        fun ensureKeyRegistration(key: PersistentDataKey<*>) {
-            if (table.columns.any { it.name == key.key.toString() }) {
-                registeredKeys.add(key)
-                return
-            }
-
-            registerColumn(key)
-            registeredKeys.add(key)
-        }
-
-        fun <T : Any> write(uuid: UUID, key: PersistentDataKey<T>, value: Any) {
-            getRow(uuid)
-            doWrite(uuid, key, key.type.constrainSQLTypes(value))
-        }
-
-        private fun doWrite(uuid: UUID, key: PersistentDataKey<*>, constrainedValue: Any) {
-            val column: Column<Any> = getColumn(key) as Column<Any>
-
-            executor.submit {
-                transaction(database) {
-                    table.update({ table.id eq uuid }) {
-                        it[column] = constrainedValue
-                    }
-                }
-            }
-        }
-
-        fun saveKeysForRow(uuid: UUID, keys: Set<PersistentDataKey<*>>) {
-            saveRow(uuid, keys)
-        }
-
-        private fun saveRow(uuid: UUID, keys: Set<PersistentDataKey<*>>) {
-            val profile = handler.loadGenericProfile(uuid)
-
-            executor.submit {
-                transaction(database) {
-                    getRow(uuid)
-
-                    for (key in keys) {
-                        doWrite(uuid, key, key.type.constrainSQLTypes(profile.read(key)))
-                    }
-                }
-            }
-        }
-
-        fun <T> read(uuid: UUID, key: PersistentDataKey<T>): T? {
-            val doRead = Callable<T?> {
-                transaction(database) {
-                    val row = getRow(uuid)
-                    val column = getColumn(key)
-                    val raw = row[column]
-                    key.type.fromConstrained(raw)
-                }
-            }
-
-            ensureKeyRegistration(key) // DON'T DELETE THIS LINE! I know it's covered in getColumn, but I need to do it here as well.
-
-            doRead.call()
-
-            return if (Eco.get().ecoPlugin.configYml.getBool("mysql.async-reads")) {
-                executor.submit(doRead).get()
-            } else {
-                doRead.call()
-            }
-        }
-
-        private fun <T> registerColumn(key: PersistentDataKey<T>) {
-            try {
-                transaction(database) {
-                    try {
-                        table.apply {
-                            if (table.columns.any { it.name == key.key.toString() }) {
-                                return@apply
-                            }
-
-                            when (key.type) {
-                                PersistentDataKeyType.INT -> registerColumn<Int>(key.key.toString(), IntegerColumnType())
-                                    .default(key.defaultValue as Int)
-
-                                PersistentDataKeyType.DOUBLE -> registerColumn<Double>(
-                                    key.key.toString(),
-                                    DoubleColumnType()
-                                ).default(key.defaultValue as Double)
-
-                                PersistentDataKeyType.BOOLEAN -> registerColumn<Boolean>(
-                                    key.key.toString(),
-                                    BooleanColumnType()
-                                ).default(key.defaultValue as Boolean)
-
-                                PersistentDataKeyType.STRING -> registerColumn<String>(
-                                    key.key.toString(),
-                                    VarCharColumnType(512)
-                                ).default(key.defaultValue as String)
-
-                                PersistentDataKeyType.STRING_LIST -> registerColumn<String>(
-                                    key.key.toString(),
-                                    VarCharColumnType(8192)
-                                ).default(PersistentDataKeyType.STRING_LIST.constrainSQLTypes(key.defaultValue as List<String>) as String)
-
-                                PersistentDataKeyType.CONFIG -> throw IllegalArgumentException(
-                                    "Config Persistent Data Keys are not supported by the legacy MySQL handler!"
-                                )
-
-                                else -> throw NullPointerException("Null value found!")
-                            }
-                        }
-
-                        SchemaUtils.createMissingTablesAndColumns(table, withLogs = false)
-                    } catch (e: Exception) {
-                        plugin.logger.info("MySQL Error 1!")
-                        e.printStackTrace()
-                        // What's that? Two enormous exception catches? That's right! This code sucks.
-                    }
-                }
-            } catch (e: Exception) {
-                plugin.logger.info("MySQL Error 2!")
-                e.printStackTrace()
-                // It might fail. Who cares? This is legacy.
-            }
-        }
-
-        private fun getColumn(key: PersistentDataKey<*>): Column<*> {
-            ensureKeyRegistration(key)
-
-            val name = key.key.toString()
-
-            return table.columns.first { it.name == name }
-        }
-
-        private fun getRow(uuid: UUID): ResultRow {
-            fun select(uuid: UUID): ResultRow? {
-                return transaction(database) {
-                    table.select { table.id eq uuid }.limit(1).singleOrNull()
-                }
-            }
-
-            return rows.get(uuid) {
-                val row = select(uuid)
-
-                return@get if (row != null) {
-                    row
-                } else {
-                    transaction(database) {
-                        table.insert { it[id] = uuid }
-                    }
-                    select(uuid)
-                }
-            }
-        }
-    }
-}
-
-private fun <T> PersistentDataKeyType<T>.constrainSQLTypes(value: Any): Any {
-    return if (this == PersistentDataKeyType.STRING_LIST) {
-        @Suppress("UNCHECKED_CAST")
-        value as List<String>
-        value.joinToString(separator = ";")
-    } else {
-        value
-    }
-}
-
-private fun <T> PersistentDataKeyType<T>.fromConstrained(constrained: Any?): T? {
-    if (constrained == null) {
-        return null
-    }
-
-    @Suppress("UNCHECKED_CAST")
-    return if (this == PersistentDataKeyType.STRING_LIST) {
-        constrained as String
-        constrained.split(";").toList()
-    } else {
-        constrained
-    } as T
-}

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/data/storage/MySQLDataHandler.kt

@@ -34,7 +34,7 @@ Whatever. At least it works.
 
 @Suppress("UNCHECKED_CAST")
 class MySQLDataHandler(
-    private val plugin: EcoSpigotPlugin,
+    plugin: EcoSpigotPlugin,
     private val handler: ProfileHandler
 ) : DataHandler(HandlerType.MYSQL) {
     private val database: Database
@@ -149,9 +149,4 @@ class MySQLDataHandler(
             SchemaUtils.createMissingTablesAndColumns(table, withLogs = false)
         }
     }
-
-    override fun save() {
-        plugin.dataYml.set("new-mysql", true)
-        plugin.dataYml.save()
-    }
 }

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/math/DelegatedExpressionHandler.kt

@@ -4,23 +4,21 @@ import com.github.benmanes.caffeine.cache.Cache
 import com.github.benmanes.caffeine.cache.Caffeine
 import com.willfp.eco.core.EcoPlugin
 import com.willfp.eco.core.placeholder.context.PlaceholderContext
-import java.util.Objects
 import java.util.concurrent.TimeUnit
 
 class DelegatedExpressionHandler(
     plugin: EcoPlugin,
     private val handler: ExpressionHandler
-): ExpressionHandler {
+) : ExpressionHandler {
     private val evaluationCache: Cache<Int, Double> = Caffeine.newBuilder()
         .expireAfterWrite(plugin.configYml.getInt("math-cache-ttl").toLong(), TimeUnit.MILLISECONDS)
         .build()
 
     override fun evaluate(expression: String, context: PlaceholderContext): Double {
-        val hash = Objects.hash(
-            expression,
-            context.player?.uniqueId,
-            context.injectableContext
-        )
+        // Peak performance (totally not having fun with bitwise operators)
+        val hash = (((expression.hashCode() shl 5) - expression.hashCode()) xor
+                (context.player?.uniqueId?.hashCode() ?: 0)
+                ) xor context.injectableContext.hashCode()
 
         return evaluationCache.get(hash) {
             handler.evaluate(expression, context)

gradle.properties

@@ -1,3 +1,3 @@
-version = 6.57.0
+version = 6.57.2
 plugin-name = eco
 kotlin.code.style = official