Fixed long standing bug with ItemProvider (and scyther integration)

eco-api/src/main/java/com/willfp/eco/core/items/Items.java

@@ -230,8 +230,8 @@ public final class Items {
 
                 String reformattedKey = keyID.replace("__", ":");
 
-                item = provider.provideForKey(reformattedKey);
-                if (item instanceof EmptyTestableItem || item == null) {
+                part = provider.provideForKey(reformattedKey);
+                if (part instanceof EmptyTestableItem || part == null) {
                     return new EmptyTestableItem();
                 }
                 registerCustomItem(namespacedKey, item);

eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/integrations/customitems/CustomItemsScyther.kt

@@ -27,11 +27,11 @@ class CustomItemsScyther : CustomItemsIntegration {
                 Scyther.getInstance(),
                 material,
                 0,
-                null,
+                1.0,
                 1,
                 Int.MAX_VALUE,
-                null,
-                null
+                "AUTOSELL",
+                true
             )
 
             val namespacedKey = NamespacedKeyUtils.create("scyther", key)