Repo-Mirror/SparklyPaperMC
9
0
Fork 0
mirror of https://github.com/SparklyPower/SparklyPaper.git synced 2025-12-19 15:09:27 +00:00
Code Issues Releases Activity

[ci skip] Add info about why patch "Optimize-random-calls-in-chunk-ticking" is borked

Browse Source
This commit is contained in:
MrPowerGamerBR
2023-11-22 02:28:35 -03:00
parent 5457114057
commit 3c39cf0c25
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
docs/BORKED_PATCHES.md
View File

@@ -4,9 +4,16 @@ List of *maybe* borked and *maybe* useless patches that I found in other fork's
Keep in mind that I'm very naive when it comes to Minecraft Server internals, so I may be wrong! Keep in mind that I'm very naive when it comes to Minecraft Server internals, so I may be wrong!
## (Pufferfish) `Optimize-random-calls-in-chunk-ticking`
The ice improvements are... not there for some reason? They did implement the `currentIceAndSnowTick` variable and `resetIceAndSnowTick()` function that the original patch from Airplane had, but the variable is never used when ticking the chunks!
As a reference, here's Airplane's original patch: https://github.com/TECHNOVE/Airplane/blob/af3563c98bdd8b27123e3a656de261ed96652b3e/patches/server/0009-Optimize-random-calls-in-chunk-ticking.patch
## (Pufferfish) `Reduce-entity-allocations` ## (Pufferfish) `Reduce-entity-allocations`
While not useless, the patch adds a `cachedBlockPos` variable that is never used by any other patch. Heck, not even in Airplane it was used! While not useless, the patch adds a `cachedBlockPos` variable that is never used by any other patch. Heck, not even in Airplane it was used!
## (Pufferfish) `Skip-cloning-loot-parameters` ## (Pufferfish) `Skip-cloning-loot-parameters`
Unnnecessarily wraps `parameters` and `dynamicDrops` into a unmodifiable map, causing unnecessary allocations. Unnnecessarily wraps `parameters` and `dynamicDrops` into a unmodifiable map, causing unnecessary allocations.