GeyserMC-Mirror/Geyser
1
0
Fork 0
mirror of https://github.com/GeyserMC/Geyser.git synced 2026-01-04 15:31:36 +00:00
Code Issues Releases Activity

Prevent concurrency issues with SkinProvider#requestedSkins

Browse Source 
There is a small potential here to return null if containsKey runs before remove and then get is called.
This commit is contained in:
Camotoy
2021-09-10 16:32:09 -04:00
parent b69cc8eba5
commit 3632ebda8b
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
connector/src/main/java/org/geysermc/connector/skin/SkinProvider.java
View File

@@ -163,7 +163,11 @@ public class SkinProvider {
public static CompletableFuture<Skin> requestSkin(UUID playerId, String textureUrl, boolean newThread) {
if (textureUrl == null || textureUrl.isEmpty()) return CompletableFuture.completedFuture(EMPTY_SKIN);
if (requestedSkins.containsKey(textureUrl)) return requestedSkins.get(textureUrl); // already requested
CompletableFuture<Skin> requestedSkin = requestedSkins.get(textureUrl);
if (requestedSkin != null) {
// already requested
return requestedSkin;
}
Skin cachedSkin = getCachedSkin(textureUrl);
if (cachedSkin != null) {