YueMi-Development/cloudflare-php
3
0
Fork 0
Code Issues Pull Requests Releases Activity

Code cleanup / Quality of Life updates

Browse Source 
Adapter::get, post, put, patch and delete all had non-optional parameters for $headers and $query or $body. These have been made optional. I also re-ordered the parameters as $headers was never used while $query/$body were heavily used. I also condensed and removed some duplicate calls so that every call to Adapter::get/post sends that call to Adapter::request. It could use a magic method to do this but it might make it more difficult to test.
This commit is contained in:
Darin Randal
2018-04-12 23:11:04 -04:00
parent 35ce8eadf1
commit cca073c809
31 changed files with 169 additions and 263 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/Configurations/ConfigurationsZoneLockdownTest.php
View File

@@ -16,19 +16,19 @@ class ConfigurationsZoneLockdownTest extends TestCase
$array = $configuration->getArray();
$this->assertCount(1, $array);
$this->assertObjectHasAttribute('target', $array[0]);
$this->assertEquals('ip', $array[0]->target);
$this->assertObjectHasAttribute('value', $array[0]);
$this->assertEquals('1.2.3.4', $array[0]->value);
$this->assertArrayHasKey('target', $array[0]);
$this->assertEquals('ip', $array[0]['target']);
$this->assertArrayHasKey('value', $array[0]);
$this->assertEquals('1.2.3.4', $array[0]['value']);
$configuration->addIPRange('1.2.3.4/24');
$array = $configuration->getArray();
$this->assertCount(2, $array);
$this->assertObjectHasAttribute('target', $array[1]);
$this->assertEquals('ip_range', $array[1]->target);
$this->assertObjectHasAttribute('value', $array[1]);
$this->assertEquals('1.2.3.4/24', $array[1]->value);
$this->assertArrayHasKey('target', $array[1]);
$this->assertEquals('ip_range', $array[1]['target']);
$this->assertArrayHasKey('value', $array[1]);
$this->assertEquals('1.2.3.4/24', $array[1]['value']);
}
}