YueMi-Development/cloudflare-php
3
0
Fork 0
Code Issues Pull Requests Releases Activity

Enabled PHPMD for src and tests

Browse Source
This commit is contained in:
Junade Ali
2017-10-13 15:18:08 +01:00
parent f0213ecf92
commit ca9e5bbc28
11 changed files with 64 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Configurations/PageRulesActions.php
View File

@@ -159,12 +159,12 @@ class PageRulesActions implements Configurations
]);
}
public function setMinification(bool $html, bool $css, bool $js)
public function setMinification(bool $html, bool $css, bool $javascript)
{
$this->addConfigurationOption("minification", [
'html' => $this->getBoolAsOnOrOff($html),
'css' => $this->getBoolAsOnOrOff($css),
'js' => $this->getBoolAsOnOrOff($js),
'js' => $this->getBoolAsOnOrOff($javascript),
]);
}
@@ -297,9 +297,9 @@ class PageRulesActions implements Configurations
return $this->configs;
}
private function addConfigurationOption($id, array $configuration)
private function addConfigurationOption(string $setting, array $configuration)
{
$configuration['id'] = $id;
$configuration['id'] = $setting;
array_push($this->configs, (object) $configuration);
}