Merge pull request #23 from cloudflare/cacheoncookie-patch
Correct input types for (Bypass) Cache on Cookie
This commit is contained in:
@@ -40,7 +40,7 @@ class PageRulesActions implements Configurations
|
||||
]);
|
||||
}
|
||||
|
||||
public function setBypassCacheOnCookie(bool $value)
|
||||
public function setBypassCacheOnCookie(string $value)
|
||||
{
|
||||
if (preg_match('/^([a-zA-Z0-9\.=|_*-]+)$/i', $value) < 1) {
|
||||
throw new ConfigurationsException("Invalid cookie string.");
|
||||
@@ -76,7 +76,7 @@ class PageRulesActions implements Configurations
|
||||
]);
|
||||
}
|
||||
|
||||
public function setCacheOnCookie(bool $value)
|
||||
public function setCacheOnCookie(string $value)
|
||||
{
|
||||
if (preg_match('/^([a-zA-Z0-9\.=|_*-]+)$/i', $value) < 1) {
|
||||
throw new ConfigurationsException("Invalid cookie string.");
|
||||
|
||||
@@ -93,13 +93,13 @@ class DNSTest extends TestCase
|
||||
$mock = $this->getMockBuilder(\Cloudflare\API\Adapter\Adapter::class)->getMock();
|
||||
$mock->method('put')->willReturn($response);
|
||||
|
||||
$details = array(
|
||||
$details = [
|
||||
'type' => 'A',
|
||||
'name' => "example.com",
|
||||
'content' => "1.2.3.4",
|
||||
'ttl' => 120,
|
||||
'proxied' => false,
|
||||
);
|
||||
];
|
||||
|
||||
$mock->expects($this->once())
|
||||
->method('put')
|
||||
|
||||
Reference in New Issue
Block a user