From 6a29d75001da6208ae94e90fbaad5d0136190ef8 Mon Sep 17 00:00:00 2001 From: easelify Date: Fri, 17 May 2019 20:18:22 +0800 Subject: [PATCH] Fix updatePageRule() method --- src/Endpoints/PageRules.php | 4 ++-- tests/Endpoints/PageRulesTest.php | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Endpoints/PageRules.php b/src/Endpoints/PageRules.php index 3e56007..df0290f 100644 --- a/src/Endpoints/PageRules.php +++ b/src/Endpoints/PageRules.php @@ -111,6 +111,7 @@ class PageRules implements API public function updatePageRule( string $zoneID, + string $ruleID, PageRulesTargets $target = null, PageRulesActions $actions = null, bool $active = null, @@ -134,8 +135,7 @@ class PageRules implements API $options['priority'] = $priority; } - - $query = $this->adapter->patch('zones/' . $zoneID . '/pagerules', $options); + $query = $this->adapter->patch('zones/' . $zoneID . '/pagerules/' . $ruleID, $options); $this->body = json_decode($query->getBody()); diff --git a/tests/Endpoints/PageRulesTest.php b/tests/Endpoints/PageRulesTest.php index f2813fd..f16815a 100644 --- a/tests/Endpoints/PageRulesTest.php +++ b/tests/Endpoints/PageRulesTest.php @@ -49,7 +49,7 @@ class PageRulesTest extends TestCase ->method('get') ->with( $this->equalTo('zones/023e105f4ecef8ad9ca31a8372d0c353/pagerules'), - $this->equalTo([ + $this->equalTo([ 'status' => 'active', 'order' => 'status', 'direction' => 'desc', @@ -94,7 +94,7 @@ class PageRulesTest extends TestCase $mock->expects($this->once()) ->method('patch') ->with( - $this->equalTo('zones/023e105f4ecef8ad9ca31a8372d0c353/pagerules'), + $this->equalTo('zones/023e105f4ecef8ad9ca31a8372d0c353/pagerules/9a7806061c88ada191ed06f989cc3dac'), $this->equalTo([ 'targets' => $target->getArray(), 'actions' => $action->getArray(), @@ -104,7 +104,7 @@ class PageRulesTest extends TestCase ); $pageRules = new \Cloudflare\API\Endpoints\PageRules($mock); - $result = $pageRules->updatePageRule('023e105f4ecef8ad9ca31a8372d0c353', $target, $action, true, 1); + $result = $pageRules->updatePageRule('023e105f4ecef8ad9ca31a8372d0c353', '9a7806061c88ada191ed06f989cc3dac', $target, $action, true, 1); $this->assertTrue($result); $this->assertEquals('9a7806061c88ada191ed06f989cc3dac', $pageRules->getBody()->result->id);