From 68d862f7daeade4c53fe2217d9f5c213069e5138 Mon Sep 17 00:00:00 2001 From: Vitaliy Dotsenko Date: Mon, 8 Jul 2019 20:08:57 +0300 Subject: [PATCH] Changed return value of the "createFirewallRules" method --- src/Endpoints/Firewall.php | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Endpoints/Firewall.php b/src/Endpoints/Firewall.php index 84791f0..9772951 100644 --- a/src/Endpoints/Firewall.php +++ b/src/Endpoints/Firewall.php @@ -16,11 +16,17 @@ class Firewall implements API public function createFirewallRules( string $zoneID, array $rules - ): array { + ): bool { $query = $this->adapter->post('zones/' . $zoneID . '/firewall/rules', $rules); $body = json_decode($query->getBody()); - return $body->result; + foreach ($body->result as $result) { + if (!isset($result->id)) { + return false; + } + } + + return true; } public function createFirewallRule( @@ -30,7 +36,7 @@ class Firewall implements API string $description = null, bool $paused = false, int $priority = null - ): array { + ): bool { $rule = [ 'filter' => [ 'expression' => $expression,