Delombok 10/10 - Removed lombok dependency, cleaned up
This commit is contained in:
@@ -5,20 +5,17 @@
|
||||
- The pull request must not have any checkstyle issues.
|
||||
- Every method and field must have a javadoc attached.
|
||||
|
||||
2. Use lombok wherever possible.
|
||||
- @Getter, @Setter, @UtilityClass only.
|
||||
|
||||
3. Use JetBrains annotations
|
||||
2. Use JetBrains annotations
|
||||
- Every parameter should be annotated with @NotNull or @Nullable
|
||||
- Use @NotNull over lombok @NonNull
|
||||
|
||||
4. Imports
|
||||
3. Imports
|
||||
- No group (*) imports.
|
||||
- No static imports.
|
||||
|
||||
## Dependency Injection
|
||||
- eco uses Dependency Injection
|
||||
- Any calls to AbstractEcoPlugin#getInstance are code smells and should never be used unless **absolutely necessary**.
|
||||
- Any calls to Eco#getHandler#getEcoPlugin are code smells and should never be used unless **absolutely necessary**.
|
||||
- NamespacedKeys, FixedMetadataValues, Runnables, and Schedules should be managed using AbstractEcoPlugin through DI.
|
||||
- Any DI class should extend PluginDependent where possible. If the class extends another, then you **must** store the plugin instance in a private final variable called **plugin** with a private or protected getter.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user