Updated proxy errors

eco-api/src/main/java/com/willfp/eco/core/EcoPlugin.java

@@ -635,7 +635,7 @@ public abstract class EcoPlugin extends JavaPlugin implements PluginLike {
      * @return The proxy.
      */
     public final <T> T getProxy(@NotNull final Class<T> proxyClass) {
-        Validate.notNull(proxyFactory, "Plugin does not support proxy!");
+        Validate.notNull(proxyFactory, "Plugin does not support proxies!");
 
         return proxyFactory.getProxy(proxyClass);
     }

eco-api/src/main/java/com/willfp/eco/core/proxy/exceptions/ProxyError.java

@@ -5,12 +5,26 @@ import org.jetbrains.annotations.NotNull;
 /**
  * Generic error with proxy loading.
  */
-public class ProxyError extends RuntimeException {
+public class ProxyError extends Error {
     /**
      * Thrown if there is an error getting a proxy.
      *
      * @param message The message to send.
+     * @param cause   The cause.
      */
+    public ProxyError(@NotNull final String message,
+                      @NotNull final Throwable cause) {
+        super(message, cause);
+    }
+
+    /**
+     * Thrown if there is an error getting a proxy.
+     *
+     * @param message The message to send.
+     * @deprecated Proxy Errors should include a cause.
+     */
+    @Deprecated
+    @SuppressWarnings("DeprecatedIsStillUsed")
     public ProxyError(@NotNull final String message) {
         super(message);
     }

eco-api/src/main/java/com/willfp/eco/core/proxy/exceptions/UnsupportedVersionException.java

@@ -1,5 +1,6 @@
 package com.willfp.eco.core.proxy.exceptions;
 
+import com.willfp.eco.core.proxy.ProxyConstants;
 import org.jetbrains.annotations.NotNull;
 
 /**
@@ -10,8 +11,17 @@ public class UnsupportedVersionException extends ProxyError {
      * Thrown if the server is running an unsupported NMS version.
      *
      * @param message The message to send.
+     * @deprecated Use the default constructor.
      */
+    @Deprecated(since = "6.24.0")
     public UnsupportedVersionException(@NotNull final String message) {
         super(message);
     }
+
+    /**
+     * Thrown if the server is running an unsupported NMS version.
+     */
+    public UnsupportedVersionException() {
+        super("You're running an unsupported server version: " + ProxyConstants.NMS_VERSION);
+    }
 }

eco-core/core-backend/src/main/kotlin/com/willfp/eco/internal/proxy/EcoProxyFactory.kt

@@ -34,21 +34,26 @@ class EcoProxyFactory(
                 return proxy
             }
         } catch (e: Exception) {
-            throwError(e)
+            throw proxyErrorFrom(e)
         }
 
-        throwError(IllegalArgumentException())
+        throw proxyErrorFrom(IllegalArgumentException("Class doesn't seem to be a proxy."))
-
-        throw RuntimeException("Something went wrong.")
     }
 
-    private fun throwError(e: Exception?) {
+    private fun proxyErrorFrom(e: Exception): Throwable {
-        e?.printStackTrace()
+        plugin.logger.severe("Fatal error with proxies! This plugin can't load.")
 
         if (!SUPPORTED_VERSIONS.contains(ProxyConstants.NMS_VERSION)) {
-            throw UnsupportedVersionException("You're running an unsupported server version: " + ProxyConstants.NMS_VERSION)
+            throw ProxyError(
+                "Could not initialize proxy.",
+                UnsupportedVersionException()
+            )
         } else {
-            throw ProxyError("Error with proxies - here's a stacktrace. Only god can help you now.")
+            throw ProxyError(
+                "Could not initialize proxy. If you're seeing this error message"
+                        + ", something has gone badly wrong. This almost definitely isn't user error, blame the developer.",
+                e
+            )
         }
     }