优化实现

bukkit/src/main/java/net/momirealms/craftengine/bukkit/font/BukkitFontManager.java

@@ -31,8 +31,7 @@ import org.bukkit.inventory.meta.BookMeta;
 import org.bukkit.inventory.view.AnvilView;
 
 import java.lang.reflect.InvocationTargetException;
-import java.util.List;
-import java.util.UUID;
+import java.util.*;
 import java.util.stream.Collectors;
 
 public class BukkitFontManager extends AbstractFontManager implements Listener {
@@ -47,9 +46,7 @@ public class BukkitFontManager extends AbstractFontManager implements Listener {
     @Override
     public void delayedInit() {
         if (this.plugin.isPluginEnabled("LuckPerms")) {
-            luckPermsEventListeners = new LuckPermsEventListeners(
-                    plugin.bootstrap(), this::refreshEmojiSuggestions, plugin.scheduler()
-            );
+            luckPermsEventListeners = new LuckPermsEventListeners(plugin.bootstrap(), this::refreshEmojiSuggestions);
         }
         Bukkit.getPluginManager().registerEvents(this, plugin.bootstrap());
     }
@@ -65,49 +62,46 @@ public class BukkitFontManager extends AbstractFontManager implements Listener {
 
     @Override
     public void delayedLoad() {
-        List<String> oldCachedEmojiSuggestions = this.oldCachedEmojiSuggestions();
+        Collection<? extends Player> players = Bukkit.getOnlinePlayers();
+        for (Player player : players) {
+            removeEmojiSuggestions(player);
+        }
         super.delayedLoad();
-        this.oldCachedEmojiSuggestions.addAll(this.cachedEmojiSuggestions());
-        Bukkit.getOnlinePlayers().forEach(player -> {
-            player.removeCustomChatCompletions(oldCachedEmojiSuggestions);
-            this.addEmojiSuggestions(player);
-        });
+        for (Player player : players) {
+            this.addEmojiSuggestions(player, getEmojiSuggestion(player));
+        }
     }
 
     @EventHandler(priority = EventPriority.LOWEST)
     public void onPlayerJoin(PlayerJoinEvent event) {
-        plugin.scheduler().async().execute(() -> {
-            Player player = event.getPlayer();
-            this.addEmojiSuggestions(player);
-        });
+        plugin.scheduler().async().execute(() -> this.addEmojiSuggestions(event.getPlayer(), getEmojiSuggestion(event.getPlayer())));
     }
 
-    public void refreshEmojiSuggestions(UUID playerUUID, boolean isAsync) {
-        if (isAsync) {
-            plugin.scheduler().async().execute(() -> {
-                Player player = Bukkit.getPlayer(playerUUID);
-                if (player == null) return;
-                player.removeCustomChatCompletions(oldCachedEmojiSuggestions);
-                this.addEmojiSuggestions(player);
-            });
-        } else {
-            Player player = Bukkit.getPlayer(playerUUID);
-            if (player == null) return;
-            player.removeCustomChatCompletions(oldCachedEmojiSuggestions);
-            this.addEmojiSuggestions(player);
+    private void refreshEmojiSuggestions(UUID uuid) {
+        Player player = Bukkit.getPlayer(uuid);
+        if (player == null) return;
+        removeEmojiSuggestions(player);
+        addEmojiSuggestions(player, getEmojiSuggestion(player));
+    }
+
+    private List<String> getEmojiSuggestion(Player player) {
+        List<String> suggestions = new ArrayList<>();
+        for (Emoji emoji : super.emojiList) {
+            if (emoji.permission() == null || player.hasPermission(Objects.requireNonNull(emoji.permission()))) {
+                suggestions.addAll(emoji.keywords());
+            }
         }
+        return suggestions;
     }
 
-    private void addEmojiSuggestions(Player player) {
-        List<String> hasPermissions = cachedEmojiSuggestions().stream()
-                .filter(keyword -> {
-                    Emoji emoji = super.emojiMapper.get(keyword);
-                    if (emoji == null) return false;
-                    String permission = emoji.permission();
-                    return permission == null || player.hasPermission(permission);
-                })
-                .collect(Collectors.toList());
-        player.addCustomChatCompletions(hasPermissions);
+    private void addEmojiSuggestions(Player player, List<String> suggestions) {
+        player.addCustomChatCompletions(suggestions);
+    }
+
+    private void removeEmojiSuggestions(Player player) {
+        if (super.allEmojiSuggestions != null) {
+            player.removeCustomChatCompletions(super.allEmojiSuggestions);
+        }
     }
 
     @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)

bukkit/src/main/java/net/momirealms/craftengine/bukkit/plugin/network/BukkitNetworkManager.java

@@ -443,10 +443,10 @@ public class BukkitNetworkManager implements NetworkManager, Listener, PluginMes
                 NMSPacketEvent event = new NMSPacketEvent(packet);
                 onNMSPacketSend(player, event, packet);
                 if (event.isCancelled()) return;
-                if (!event.hasNewPacket()) {
-                    super.write(context, packet, channelPromise);
+                if (event.isUsingNewPacket()) {
+                    super.write(context, event.optionalNewPacket(), channelPromise);
                 } else {
-                    super.write(context, event.getNewPacket(), channelPromise);
+                    super.write(context, packet, channelPromise);
                 }
                 channelPromise.addListener((p) -> {
                     for (Runnable task : event.getDelayedTasks()) {
@@ -464,10 +464,10 @@ public class BukkitNetworkManager implements NetworkManager, Listener, PluginMes
             NMSPacketEvent event = new NMSPacketEvent(packet);
             onNMSPacketReceive(player, event, packet);
             if (event.isCancelled()) return;
-            if (!event.hasNewPacket()) {
-                super.channelRead(context, packet);
+            if (event.isUsingNewPacket()) {
+                super.channelRead(context, event.optionalNewPacket());
             } else {
-                super.channelRead(context, event.getNewPacket());
+                super.channelRead(context, packet);
             }
         }
     }

bukkit/src/main/java/net/momirealms/craftengine/bukkit/plugin/network/NMSPacketEvent.java

@@ -1,19 +1,18 @@
 package net.momirealms.craftengine.bukkit.plugin.network;
 
 import net.momirealms.craftengine.core.util.Cancellable;
+import org.jetbrains.annotations.NotNull;
 
-import javax.annotation.Nullable;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
 
 public class NMSPacketEvent implements Cancellable {
-    private boolean cancelled;
-    private boolean hasNewPacket;
-    private List<Runnable> delayedTasks = null;
     private final Object packet;
-    private Object newPacket;
+    private boolean cancelled;
+    private List<Runnable> delayedTasks = null;
+    private Object newPacket = null;
 
     public NMSPacketEvent(Object packet) {
         this.packet = packet;
@@ -23,17 +22,15 @@ public class NMSPacketEvent implements Cancellable {
         return packet;
     }
 
-    public void setNewPacket(Object newPacket) {
-        hasNewPacket = true;
+    public void replacePacket(@NotNull Object newPacket) {
         this.newPacket = newPacket;
     }
 
-    public boolean hasNewPacket() {
-        return hasNewPacket;
+    public boolean isUsingNewPacket() {
+        return newPacket != null;
     }
 
-    @Nullable
-    public Object getNewPacket() {
+    public Object optionalNewPacket() {
         return newPacket;
     }
 

bukkit/src/main/java/net/momirealms/craftengine/bukkit/plugin/network/PacketConsumers.java

@@ -362,7 +362,7 @@ public class PacketConsumers {
                 isChanged = true;
             }
             if (isChanged) {
-                event.setNewPacket(FastNMS.INSTANCE.constructor$ClientboundPlayerInfoUpdatePacket(enums, newEntries));
+                event.replacePacket(FastNMS.INSTANCE.constructor$ClientboundPlayerInfoUpdatePacket(enums, newEntries));
             }
         } catch (Exception e) {
             CraftEngine.instance().logger().warn("Failed to handle ClientboundPlayerInfoUpdatePacket", e);
@@ -1778,7 +1778,7 @@ public class PacketConsumers {
                         newPages,
                         newTitle
                 );
-                event.setNewPacket(newPacket);
+                event.replacePacket(newPacket);
             }
         } catch (Exception e) {
             CraftEngine.instance().logger().warn("Failed to handle ServerboundEditBookPacket", e);