Update to Paper 1.21.4 (post hard fork™️ edition)

sparklypaper-server/minecraft-patches/features/0007-Spooky-month-optimizations.patch

@@ -0,0 +1,109 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: MrPowerGamerBR <git@mrpowergamerbr.com>
+Date: Tue, 21 Nov 2023 16:50:04 -0300
+Subject: [PATCH] Spooky month optimizations
+
+The quintessential patch that other performance forks also have for... some reason??? I thought that this optimization was too funny to not do it in SparklyPaper.
+
+Caches when Bat's spooky season starts and ends, and when Skeleton and Zombies halloween starts and ends. The epoch is updated every 90 days. If your server is running for 90+ days straight without restarts, congratulations!
+
+Avoids unnecessary date checks, even tho that this shouldn't really improve performance that much... unless you have a lot of bats/zombies/skeletons spawning.
+
+diff --git a/net/minecraft/server/MinecraftServer.java b/net/minecraft/server/MinecraftServer.java
+index 6ad6bfe60026be304aa2178d5f04a79531cc66a6..4dbf2d9aa52029122f4816ca3504fa330b28a29b 100644
+--- a/net/minecraft/server/MinecraftServer.java
++++ b/net/minecraft/server/MinecraftServer.java
+@@ -304,6 +304,7 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
+     private final Set<String> pluginsBlockingSleep = new java.util.HashSet<>(); // Paper - API to allow/disallow tick sleeping
+     public static final long SERVER_INIT = System.nanoTime(); // Paper - Lag compensation
+     public final Set<net.minecraft.world.entity.Entity> entitiesWithScheduledTasks = java.util.concurrent.ConcurrentHashMap.newKeySet(); // SparklyPaper - skip EntityScheduler's executeTick checks if there isn't any tasks to be run (concurrent because plugins may schedule tasks async)
++    public net.sparklypower.sparklypaper.HalloweenManager halloweenManager = new net.sparklypower.sparklypaper.HalloweenManager(); // SparklyPaper - Spooky month optimizations
+ 
+     public static <S extends MinecraftServer> S spin(Function<Thread, S> threadFunction) {
+         ca.spottedleaf.dataconverter.minecraft.datatypes.MCTypeRegistry.init(); // Paper - rewrite data converter system
+diff --git a/net/minecraft/server/dedicated/DedicatedServer.java b/net/minecraft/server/dedicated/DedicatedServer.java
+index 4c420e17d936132bb4569776911757fd959e93d6..6ac73610f6039290c4ef3dde2206b6863d2b5067 100644
+--- a/net/minecraft/server/dedicated/DedicatedServer.java
++++ b/net/minecraft/server/dedicated/DedicatedServer.java
+@@ -233,6 +233,10 @@ public class DedicatedServer extends MinecraftServer implements ServerInterface
+         }
+         net.sparklypower.sparklypaper.SparklyPaperCommands.INSTANCE.registerCommands(this);
+         // SparklyPaper end
++        // SparklyPaper start - Spooky month optimizations
++        halloweenManager.startHalloweenEpochTask();
++        halloweenManager.waitUntilEpochHasBeenUpdated();
++        // SparklyPaper end
+         com.destroystokyo.paper.VersionHistoryManager.INSTANCE.getClass(); // Paper - load version history now
+ 
+         this.setPvpAllowed(properties.pvp);
+diff --git a/net/minecraft/world/entity/ambient/Bat.java b/net/minecraft/world/entity/ambient/Bat.java
+index 5ebe7b1dce367d5c5e1136b97b2b9f6737595201..b003fa86fab9a6106c9875205d73e49e46904498 100644
+--- a/net/minecraft/world/entity/ambient/Bat.java
++++ b/net/minecraft/world/entity/ambient/Bat.java
+@@ -231,7 +231,7 @@ public class Bat extends AmbientCreature {
+         } else {
+             int maxLocalRawBrightness = level.getMaxLocalRawBrightness(pos);
+             int i = 4;
+-            if (isHalloween()) {
++            if (level.getServer().halloweenManager.isSpookySeason()) {
+                 i = 7;
+             } else if (randomSource.nextBoolean()) {
+                 return false;
+@@ -243,12 +243,15 @@ public class Bat extends AmbientCreature {
+         }
+     }
+ 
++    // SparklyPaper - Spooky month optimizations
++    /*
+     private static boolean isHalloween() {
+         LocalDate localDate = LocalDate.now();
+         int i = localDate.get(ChronoField.DAY_OF_MONTH);
+         int i1 = localDate.get(ChronoField.MONTH_OF_YEAR);
+         return i1 == 10 && i >= 20 || i1 == 11 && i <= 3;
+     }
++    */
+ 
+     private void setupAnimationStates() {
+         if (this.isResting()) {
+diff --git a/net/minecraft/world/entity/monster/AbstractSkeleton.java b/net/minecraft/world/entity/monster/AbstractSkeleton.java
+index 37abc7769573e3cdda380166dd086551d5e7bd88..be623fd09ca573922297d3af3cd114160ec05061 100644
+--- a/net/minecraft/world/entity/monster/AbstractSkeleton.java
++++ b/net/minecraft/world/entity/monster/AbstractSkeleton.java
+@@ -158,10 +158,12 @@ public abstract class AbstractSkeleton extends Monster implements RangedAttackMo
+         this.reassessWeaponGoal();
+         this.setCanPickUpLoot(this.level().paperConfig().entities.behavior.mobsCanAlwaysPickUpLoot.skeletons || random.nextFloat() < 0.55F * difficulty.getSpecialMultiplier()); // Paper - Add world settings for mobs picking up loot
+         if (this.getItemBySlot(EquipmentSlot.HEAD).isEmpty()) {
+-            LocalDate localDate = LocalDate.now();
+-            int i = localDate.get(ChronoField.DAY_OF_MONTH);
+-            int i1 = localDate.get(ChronoField.MONTH_OF_YEAR);
+-            if (i1 == 10 && i == 31 && random.nextFloat() < 0.25F) {
++            // SparklyPaper start - Spooky month optimizations
++            // LocalDate localDate = LocalDate.now();
++            // int i = localDate.get(ChronoField.DAY_OF_MONTH);
++            // int i1 = localDate.get(ChronoField.MONTH_OF_YEAR);
++            if (this.getServer().halloweenManager.isHalloween() /* i1 == 10 && i == 31 */&& random.nextFloat() < 0.25F) {
++                // SparklyPaper end
+                 this.setItemSlot(EquipmentSlot.HEAD, new ItemStack(random.nextFloat() < 0.1F ? Blocks.JACK_O_LANTERN : Blocks.CARVED_PUMPKIN));
+                 this.armorDropChances[EquipmentSlot.HEAD.getIndex()] = 0.0F;
+             }
+diff --git a/net/minecraft/world/entity/monster/Zombie.java b/net/minecraft/world/entity/monster/Zombie.java
+index 637790ff833abaa0c52fdee204abba7077d12ccc..600b96d4b2645e26fd690ac70d3901d567b7bc24 100644
+--- a/net/minecraft/world/entity/monster/Zombie.java
++++ b/net/minecraft/world/entity/monster/Zombie.java
+@@ -550,10 +550,12 @@ public class Zombie extends Monster {
+         }
+ 
+         if (this.getItemBySlot(EquipmentSlot.HEAD).isEmpty()) {
+-            LocalDate localDate = LocalDate.now();
+-            int i = localDate.get(ChronoField.DAY_OF_MONTH);
+-            int i1 = localDate.get(ChronoField.MONTH_OF_YEAR);
+-            if (i1 == 10 && i == 31 && random.nextFloat() < 0.25F) {
++            // SparklyPaper start - Spooky month optimizations
++            // LocalDate localDate = LocalDate.now();
++            // int i = localDate.get(ChronoField.DAY_OF_MONTH);
++            // int i1 = localDate.get(ChronoField.MONTH_OF_YEAR);
++            if (this.getServer().halloweenManager.isHalloween() /* i1 == 10 && i == 31 */&& random.nextFloat() < 0.25F) {
++                // SparklyPaper end
+                 this.setItemSlot(EquipmentSlot.HEAD, new ItemStack(random.nextFloat() < 0.1F ? Blocks.JACK_O_LANTERN : Blocks.CARVED_PUMPKIN));
+                 this.armorDropChances[EquipmentSlot.HEAD.getIndex()] = 0.0F;
+             }