mirror of
https://github.com/Samsuik/Sakura.git
synced 2025-12-21 15:59:26 +00:00
Upstream has released updates that appear to apply and compile correctly Paper Changes: PaperMC/Paper@9e51f94 Fix ping event always receiving protocol version 0 (#10671) PaperMC/Paper@89ad61f Fix hopper pull event being skipped after the first call (#10667) PaperMC/Paper@eee55d0 Correctly compare holders in BeaconMenu (#10673) PaperMC/Paper@5729b29 Update Adventure to 4.17.0 Release PaperMC/Paper@ab2a85a [ci skip] Clarify var entry in contributing file PaperMC/Paper@f2512b1 Print data component type on encoding error PaperMC/Paper@1b67e02 Fix entity tracker desync when new players are added to the tracker PaperMC/Paper@cc29d2b Invalidate PathTypeCache when pathfinding updates are disabled PaperMC/Paper@b56e92f Fix chunk data version check not running in chunk system PaperMC/Paper@2df1dac Fix DataConverter ConverterParticleToNBT.parseProperties PaperMC/Paper@8748ae1 Use MCDataConverter instead of raw convert call for cmd converter PaperMC/Paper@7f1a154 Add validation to player profile and properties (#10680) PaperMC/Paper@4fd58a1 Add conversion for summon command PaperMC/Paper@39532a1 Fix stacks losing empty attr modifiers PaperMC/Paper@cdb6ba8 Fix keepalive time interval (#10690) PaperMC/Paper@a61d58d adjust ItemMeta to distinguish null and empty modifiers PaperMC/Paper@6c02dbc handle recent ItemMeta changes in serialization logic PaperMC/Paper@447f9a1 [ci skip] Fix paperclip PR label PaperMC/Paper@b98d20a Brigadier Command Support (#8235) PaperMC/Paper@ac554ad Updated Upstream (Bukkit/CraftBukkit) (#10691) PaperMC/Paper@711f82e Fix signed book page serialization (#10696) PaperMC/Paper@7e48f66 Properly pass requirement on namespaced redirects (#10701) PaperMC/Paper@f041f48 Prevent infinite recursion on cyclic brig redirect (#10705) PaperMC/Paper@11c3963 Improve Recipe validation (#10707) PaperMC/Paper@0688f21 Better way to keep paper datapack enabled PaperMC/Paper@218d33c fix creating complex recipes that have air results PaperMC/Paper@fa8a407 Remove Adventure snapshot repo from dev bundle (#10716) PaperMC/Paper@bebcc9c Make exception during command conversion non-fatal PaperMC/Paper@2faa3b2 Correctly copy alias requirements in command upgrader PaperMC/Paper@3fc9358 Show stacktrace when modifyItemStack fails PaperMC/Paper@f175193 Expose server build information (#10729) PaperMC/Paper@d8d59e0 Fix NPE sending resource pack without prompt PaperMC/Paper@5a9afbe Fixes issues in the suppress dismount cancellation patch (#10735) PaperMC/Paper@0ad09de Make PaperSimplePluginClassLoader show class which is not found PaperMC/Paper@b3b3406 fix CompassMeta not being correct (#10737) PaperMC/Paper@591521e Check for more correct profile validation (#10730) PaperMC/Paper@7d2e5c3 Add an 'empty' RecipeChoice for certain ingredient slots (#10710) PaperMC/Paper@9bf4855 Add a better warning message than "Server performance will be affected" for CommandRegisteredEvent use (#10754) PaperMC/Paper@66cb880 Remove ThreadedWorldUpgrader patch PaperMC/Paper@980cff9 Fix compile PaperMC/Paper@d3ffa62 fix default item attributes PaperMC/Paper@b149584 Always show command exception stack traces in logs (#10766) PaperMC/Paper@a9201d4 [ci skip] Move logic in our patches to ItemType/BlockType (#10772) PaperMC/Paper@3de408e Fix equipment slot and group API (#10767) PaperMC/Paper@d408381 Print CommandRegisteredEvent deprecation warnings again (#10756) PaperMC/Paper@6de7a1f Improve default item attributes API (#10765) PaperMC/Paper@2a90732 Remove incorrect logic for Fireball#setVelocity (#10764) PaperMC/Paper@5e7b65a Allow using PluginLoader classpath API from Bukkit plugins (#10758) PaperMC/Paper@3004717 Do not re-wrap vanilla goals (#10751) PaperMC/Paper@377733d Use getter/setter on Mob for equipment drop chances (#10780) PaperMC/Paper@dff591d Allow to define new map cursor types (#10782) PaperMC/Paper@4fd3ac0 [ci skip] Update Player#getListeningPluginChannels Jdoc (#10778) PaperMC/Paper@535dca5 Fix a few issues with ItemMeta (#10740) PaperMC/Paper@26e90b9 Fix CraftMetaBlockState for data components (#10731) PaperMC/Paper@f0bd0cc Expose anvil cost in the API (#10682) PaperMC/Paper@41bee55 Fix NPE for color-related metas PaperMC/Paper@4e10fad reset meta block state on BlockStateMeta#setBlockState PaperMC/Paper@a7ae966 readd itemstack data sanitization (#10454) PaperMC/Paper@ca50b87 Clear firework item properly (#10793) PaperMC/Paper@9774a52 fix and cleanup loot table patches (#10100) PaperMC/Paper@ac4ee06 Fix integer overflow for lag compensating eating check (#10797) PaperMC/Paper@6649a17 Fix BlockStateMeta equals (#10795) PaperMC/Paper@1b8cdc6 Extend Player Interact cancellation to cover Jigsaw blocks (#10719) PaperMC/Paper@841ab41 Fix more item desync when an event is cancelled (#10654) PaperMC/Paper@b0e3ca4 Prevent NPE if hooked entity was cleared (#10712) PaperMC/Paper@347bbe3 Fix Cancelling BlockPlaceEvent calling onRemove (#10773) PaperMC/Paper@23fe116 Fix missing debug trace PaperMC/Paper@b0c9b9c Only remove worldgen block entity on changed block (#10794) PaperMC/Paper@9c917fe [ci skip] Clean up paperclip build-pr workflow (#10802) PaperMC/Paper@9d6f2cc [ci skip] Rebuild patches (#10803)
583 lines
25 KiB
Diff
583 lines
25 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Samsuik <40902469+Samsuik@users.noreply.github.com>
|
|
Date: Sat, 9 Sep 2023 18:39:15 +0100
|
|
Subject: [PATCH] Merge Cannon Entities
|
|
|
|
|
|
diff --git a/src/main/java/me/samsuik/sakura/entity/merge/MergeHistory.java b/src/main/java/me/samsuik/sakura/entity/merge/MergeHistory.java
|
|
new file mode 100644
|
|
index 0000000000000000000000000000000000000000..7d899163b308f52b48bf72a1e9cd38d565bbe05d
|
|
--- /dev/null
|
|
+++ b/src/main/java/me/samsuik/sakura/entity/merge/MergeHistory.java
|
|
@@ -0,0 +1,56 @@
|
|
+package me.samsuik.sakura.entity.merge;
|
|
+
|
|
+import it.unimi.dsi.fastutil.longs.Long2ObjectMap;
|
|
+import it.unimi.dsi.fastutil.longs.Long2ObjectOpenHashMap;
|
|
+import it.unimi.dsi.fastutil.longs.LongOpenHashSet;
|
|
+import net.minecraft.server.MinecraftServer;
|
|
+import net.minecraft.world.entity.Entity;
|
|
+
|
|
+import java.util.List;
|
|
+
|
|
+public final class MergeHistory {
|
|
+
|
|
+ // packed position -> known merging information
|
|
+ private final Long2ObjectMap<SpawnPositionData> mergeDataMap = new Long2ObjectOpenHashMap<>();
|
|
+ private SpawnPositionData mergeData = null;
|
|
+
|
|
+ public SpawnPositionData retrievePositions(Entity entity) {
|
|
+ long origin = entity.getPackedOrigin();
|
|
+
|
|
+ if (mergeData != null && mergeData.isPositionKnown(origin)) {
|
|
+ return mergeData;
|
|
+ }
|
|
+
|
|
+ return mergeData = mergeDataMap.get(origin);
|
|
+ }
|
|
+
|
|
+ public void markPositions(Entity entity) {
|
|
+ List<Entity> mergeList = entity.getMergeList();
|
|
+ long origin = entity.getPackedOrigin();
|
|
+
|
|
+ // After a merged entity has been discarded store all the position data
|
|
+ SpawnPositionData data = mergeDataMap.computeIfAbsent(origin, p -> new SpawnPositionData(mergeList));
|
|
+ data.getExpiry().refresh(MinecraftServer.currentTickLong);
|
|
+
|
|
+ // Collect all merge positions
|
|
+ LongOpenHashSet positions = new LongOpenHashSet((mergeList.size() + 1) / 2);
|
|
+ positions.add(entity.getPackedOrigin());
|
|
+
|
|
+ for (Entity mergedEntity : mergeList) {
|
|
+ positions.add(mergedEntity.getPackedOrigin());
|
|
+ }
|
|
+
|
|
+ // Retain existing positions or insert new positions
|
|
+ data.retainOrInsertPositions(positions);
|
|
+ }
|
|
+
|
|
+ public void expire(long tick) {
|
|
+ mergeData = null; // clear this every tick
|
|
+
|
|
+ // only expire every 20 ticks
|
|
+ if (tick % 20 != 0) return;
|
|
+
|
|
+ mergeDataMap.values().removeIf(data -> data.getExpiry().isExpired(tick));
|
|
+ }
|
|
+
|
|
+}
|
|
diff --git a/src/main/java/me/samsuik/sakura/entity/merge/MergeThreshold.java b/src/main/java/me/samsuik/sakura/entity/merge/MergeThreshold.java
|
|
new file mode 100644
|
|
index 0000000000000000000000000000000000000000..4d08af1a7ff0ebc2b1198513c86c08087d9d6e89
|
|
--- /dev/null
|
|
+++ b/src/main/java/me/samsuik/sakura/entity/merge/MergeThreshold.java
|
|
@@ -0,0 +1,26 @@
|
|
+package me.samsuik.sakura.entity.merge;
|
|
+
|
|
+/**
|
|
+ * Threshold for AOT/on spawn merging.
|
|
+ * <p>
|
|
+ * This is determined by the amount of spawn attempts over time.
|
|
+ */
|
|
+public final class MergeThreshold {
|
|
+
|
|
+ private final long startingTick;
|
|
+ private final int thresholdAttempts;
|
|
+ private final long thresholdAge;
|
|
+ private int attempts;
|
|
+
|
|
+ public MergeThreshold(long tick, int attempts, long age) {
|
|
+ startingTick = tick;
|
|
+ thresholdAttempts = attempts;
|
|
+ thresholdAge = age;
|
|
+ }
|
|
+
|
|
+ public boolean hasPassed(long tick) {
|
|
+ return ++attempts >= thresholdAttempts
|
|
+ || tick - startingTick >= thresholdAge;
|
|
+ }
|
|
+
|
|
+}
|
|
diff --git a/src/main/java/me/samsuik/sakura/entity/merge/SpawnPositionData.java b/src/main/java/me/samsuik/sakura/entity/merge/SpawnPositionData.java
|
|
new file mode 100644
|
|
index 0000000000000000000000000000000000000000..e63935c17e213bf60571d120ad9ce311b5249d45
|
|
--- /dev/null
|
|
+++ b/src/main/java/me/samsuik/sakura/entity/merge/SpawnPositionData.java
|
|
@@ -0,0 +1,64 @@
|
|
+package me.samsuik.sakura.entity.merge;
|
|
+
|
|
+import it.unimi.dsi.fastutil.longs.LongOpenHashSet;
|
|
+import it.unimi.dsi.fastutil.longs.LongSet;
|
|
+import me.samsuik.sakura.utils.collections.EntityTable;
|
|
+import me.samsuik.sakura.utils.objects.Expiry;
|
|
+import net.minecraft.server.MinecraftServer;
|
|
+import net.minecraft.world.entity.Entity;
|
|
+
|
|
+import java.util.List;
|
|
+
|
|
+/**
|
|
+ * Contains all the positions that past entities of the same origin have merged with.
|
|
+ */
|
|
+public final class SpawnPositionData {
|
|
+
|
|
+ private final LongSet knownPositions = new LongOpenHashSet();
|
|
+ private final LongSet retainedPositions = new LongOpenHashSet();
|
|
+
|
|
+ private final EntityTable table;
|
|
+ private final Expiry expiry = new Expiry(MinecraftServer.currentTickLong, 200);
|
|
+ private final MergeThreshold threshold = new MergeThreshold(MinecraftServer.currentTickLong, 12, 200);
|
|
+
|
|
+ public SpawnPositionData(List<Entity> mergeList) {
|
|
+ this.table = new EntityTable(mergeList.size());
|
|
+ }
|
|
+
|
|
+ public Expiry getExpiry() {
|
|
+ return expiry;
|
|
+ }
|
|
+
|
|
+ public void retainOrInsertPositions(LongOpenHashSet positions) {
|
|
+ if (!knownPositions.isEmpty()) {
|
|
+ retainedPositions.addAll(positions);
|
|
+ } else {
|
|
+ retainedPositions.retainAll(positions);
|
|
+ }
|
|
+
|
|
+ knownPositions.addAll(positions);
|
|
+ }
|
|
+
|
|
+ public boolean isPositionKnown(long pos) {
|
|
+ return knownPositions.contains(pos);
|
|
+ }
|
|
+
|
|
+ public boolean isPositionRetained(long pos) {
|
|
+ return retainedPositions.contains(pos);
|
|
+ }
|
|
+
|
|
+ public boolean isAbleToOnSpawnMerge() {
|
|
+ return threshold.hasPassed(MinecraftServer.currentTickLong);
|
|
+ }
|
|
+
|
|
+ public Entity findFirstEntityInSamePosition(Entity entity) {
|
|
+ Entity found = table.locate(entity);
|
|
+
|
|
+ if (found != null && found.getId() < entity.getId() && knownPositions.contains(found.getPackedOrigin()) && !found.isRemoved() && entity.compareState(found)) {
|
|
+ return found;
|
|
+ }
|
|
+
|
|
+ return null;
|
|
+ }
|
|
+
|
|
+}
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
index b72c796d30d4892e30d726c3b2a6b097b941979d..054783956aa6179f9f0813393b7a9afa41a6d54a 100644
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
@@ -1803,6 +1803,7 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
|
|
worldserver.explosionDensityCache.clear(); // Paper - Optimize explosions
|
|
worldserver.localConfig().expire(currentTickLong); // Sakura - add local config
|
|
worldserver.minimalTNT.clear(); // Sakura - visibility api
|
|
+ worldserver.mergeHistory.expire(currentTickLong); // Sakura - merge cannoning entities
|
|
}
|
|
this.isIteratingOverLevels = false; // Paper - Throw exception on world create while being ticked
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/level/ServerLevel.java b/src/main/java/net/minecraft/server/level/ServerLevel.java
|
|
index 4a3690c71eda93d2542e8c039442a51882f10475..ada18c755cee73620e6c0020674dd0a5a1d8f79d 100644
|
|
--- a/src/main/java/net/minecraft/server/level/ServerLevel.java
|
|
+++ b/src/main/java/net/minecraft/server/level/ServerLevel.java
|
|
@@ -899,6 +899,7 @@ public class ServerLevel extends Level implements WorldGenLevel {
|
|
|
|
org.spigotmc.ActivationRange.activateEntities(this); // Spigot
|
|
this.timings.entityTick.startTiming(); // Spigot
|
|
+ Entity[] previousEntity = new Entity[1]; // Sakura
|
|
this.entityTickList.forEach((entity) -> {
|
|
if (!entity.isRemoved()) {
|
|
if (false && this.shouldDiscardEntity(entity)) { // CraftBukkit - We prevent spawning in general, so this butchering is not needed
|
|
@@ -918,6 +919,15 @@ public class ServerLevel extends Level implements WorldGenLevel {
|
|
entity.stopRiding();
|
|
}
|
|
|
|
+ // Sakura start
|
|
+ Entity previous = previousEntity[0];
|
|
+ if (entity.isMergeableType(previous) && entity.tryMergeInto(previous)) {
|
|
+ return;
|
|
+ } else {
|
|
+ previousEntity[0] = entity;
|
|
+ }
|
|
+ // Sakura end
|
|
+
|
|
gameprofilerfiller.push("tick");
|
|
this.guardEntityTick(this::tickNonPassenger, entity);
|
|
gameprofilerfiller.pop();
|
|
diff --git a/src/main/java/net/minecraft/world/entity/Entity.java b/src/main/java/net/minecraft/world/entity/Entity.java
|
|
index ce16878d3c9c52e8edd4b073916bb3f7fd595649..88964adf81cd03b26556b50b764caaddd49b59be 100644
|
|
--- a/src/main/java/net/minecraft/world/entity/Entity.java
|
|
+++ b/src/main/java/net/minecraft/world/entity/Entity.java
|
|
@@ -604,6 +604,116 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
|
|
return to.entityState() != null && to.entityState().isCurrentState(this);
|
|
}
|
|
// Sakura end - store entity data/state
|
|
+ // Sakura start - cannon entity merging
|
|
+ // List of merged entities, should be naturally sorted (oldest -> youngest)
|
|
+ private final List<Entity> mergeList = new java.util.ArrayList<>(1);
|
|
+ private @Nullable me.samsuik.sakura.entity.merge.SpawnPositionData originData = null;
|
|
+ private me.samsuik.sakura.entity.merge.MergeLevel mergeLevel;
|
|
+ protected int stacked = 1; // default
|
|
+
|
|
+ public final me.samsuik.sakura.entity.merge.MergeLevel getMergeLevel() {
|
|
+ return mergeLevel;
|
|
+ }
|
|
+
|
|
+ public final void setMergeLevel(me.samsuik.sakura.entity.merge.MergeLevel level) {
|
|
+ mergeLevel = level;
|
|
+ }
|
|
+
|
|
+ public final int getStacked() {
|
|
+ return stacked;
|
|
+ }
|
|
+
|
|
+ public final void setStacked(int stack) {
|
|
+ stacked = stack;
|
|
+ }
|
|
+
|
|
+ public final List<Entity> getMergeList() {
|
|
+ return mergeList;
|
|
+ }
|
|
+
|
|
+ public final long getPackedOrigin() {
|
|
+ var v = getOriginVector();
|
|
+ if (v == null) return Long.MIN_VALUE;
|
|
+ // Note: vector#getBlockN may not be 100% exact
|
|
+ // If there's any future issues at let's say 0.999999...
|
|
+ // giving an incorrect position change it to Mth instead.
|
|
+ return BlockPos.asLong(v.getBlockX(), v.getBlockY(), v.getBlockZ());
|
|
+ }
|
|
+
|
|
+ private boolean isSafeToSpawnMerge(Entity entity) {
|
|
+ return tickCount == 1 && originData != null
|
|
+ && originData.isAbleToOnSpawnMerge() // on spawn safety delay has passed
|
|
+ && originData == entity.originData // make sure it's the same group
|
|
+ && originData.isPositionRetained(entity.getPackedOrigin());
|
|
+ }
|
|
+
|
|
+ public boolean isMergeableType(@Nullable Entity previous) {
|
|
+ return false;
|
|
+ }
|
|
+
|
|
+ public final boolean tryMergeInto(@Nullable Entity entity) {
|
|
+ if (mergeLevel.atLeast(me.samsuik.sakura.entity.merge.MergeLevel.LENIENT) && tickCount == 0) {
|
|
+ originData = level.mergeHistory.retrievePositions(this);
|
|
+ }
|
|
+
|
|
+ Entity mergeEntity = null;
|
|
+
|
|
+ if (entity == null || entity.getType() != getType()) {
|
|
+ return false; // First entity
|
|
+ } else if (mergeLevel.atLeast(me.samsuik.sakura.entity.merge.MergeLevel.SPAWN) && entity.isSafeToSpawnMerge(this)) {
|
|
+ // "SPAWN" merges entities one gametick after they have spawned. Merging is
|
|
+ // only possible after it has been established that the entity is safe to
|
|
+ // merge by collecting information on the entities that merge together over time.
|
|
+ mergeEntity = entity;
|
|
+ } else {
|
|
+ // "STRICT" merges entities with the same properties, position, momentum and OOE.
|
|
+ // This is considered safe to use, and will not break cannon mechanics.
|
|
+ if (mergeLevel.atLeast(me.samsuik.sakura.entity.merge.MergeLevel.STRICT) && compareState(entity)) {
|
|
+ mergeEntity = entity;
|
|
+ }
|
|
+
|
|
+ // "LENIENT" merges entities aggressively by tracking the entities that have
|
|
+ // previously merged. This is a hybrid of "SPAWN" and "STRICT" merging, with the
|
|
+ // visuals of "STRICT" merging and better merging potential of "SPAWN" merging.
|
|
+ if (mergeLevel.atLeast(me.samsuik.sakura.entity.merge.MergeLevel.LENIENT) && mergeEntity == null && originData != null) {
|
|
+ mergeEntity = originData.findFirstEntityInSamePosition(this);
|
|
+ }
|
|
+ }
|
|
+
|
|
+ if (mergeEntity != null && isSafeToMergeInto(mergeEntity)) {
|
|
+ mergeInto(mergeEntity);
|
|
+ return true;
|
|
+ }
|
|
+
|
|
+ return false;
|
|
+ }
|
|
+
|
|
+ protected boolean respawnMerged() {
|
|
+ return false;
|
|
+ }
|
|
+
|
|
+ public boolean isSafeToMergeInto(Entity entity) {
|
|
+ return false;
|
|
+ }
|
|
+
|
|
+ private void mergeInto(Entity entity) {
|
|
+ entity.mergeList.add(this);
|
|
+ entity.mergeList.addAll(mergeList);
|
|
+ entity.stacked += stacked;
|
|
+
|
|
+ mergeList.clear(); // clear the list to stop our tracking when merging
|
|
+ stacked = 0; // prevent any possible duplication
|
|
+
|
|
+ discard(null); // MERGE is appropriate here but plugins may not expect tnt or falling blocks to merge
|
|
+
|
|
+ // update api handle, this is so cannondebug can function
|
|
+ //noinspection ConstantValue
|
|
+ if (bukkitEntity != null) {
|
|
+ bukkitEntity.setHandle(entity);
|
|
+ bukkitEntity = entity.bukkitEntity;
|
|
+ }
|
|
+ }
|
|
+ // Sakura end - cannon entity merging
|
|
|
|
public Entity(EntityType<?> type, Level world) {
|
|
this.id = Entity.ENTITY_COUNTER.incrementAndGet();
|
|
@@ -653,6 +763,7 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
|
|
this.entityData = datawatcher_a.build();
|
|
this.setPos(0.0D, 0.0D, 0.0D);
|
|
this.eyeHeight = this.dimensions.eyeHeight();
|
|
+ this.mergeLevel = level.sakuraConfig().cannons.mergeLevel; // Sakura
|
|
}
|
|
|
|
public boolean isColliding(BlockPos pos, BlockState state) {
|
|
@@ -2591,6 +2702,11 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
|
|
nbttagcompound.putBoolean("Paper.FreezeLock", true);
|
|
}
|
|
// Paper end
|
|
+ // Sakura start
|
|
+ if (stacked > 0) {
|
|
+ nbttagcompound.putInt("Sakura.Stacked", stacked);
|
|
+ }
|
|
+ // Sakura end
|
|
return nbttagcompound;
|
|
} catch (Throwable throwable) {
|
|
CrashReport crashreport = CrashReport.forThrowable(throwable, "Saving entity NBT");
|
|
@@ -2738,6 +2854,11 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
|
|
freezeLocked = nbt.getBoolean("Paper.FreezeLock");
|
|
}
|
|
// Paper end
|
|
+ // Sakura start
|
|
+ if (nbt.contains("Sakura.Stacked")) {
|
|
+ stacked = nbt.getInt("Sakura.Stacked");
|
|
+ }
|
|
+ // Sakura end
|
|
|
|
} catch (Throwable throwable) {
|
|
CrashReport crashreport = CrashReport.forThrowable(throwable, "Loading entity NBT");
|
|
@@ -4949,6 +5070,11 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
|
|
// Paper end - rewrite chunk system
|
|
CraftEventFactory.callEntityRemoveEvent(this, cause);
|
|
// CraftBukkit end
|
|
+ // Sakura start
|
|
+ if (entity_removalreason == RemovalReason.DISCARDED && !mergeList.isEmpty()) {
|
|
+ level.mergeHistory.markPositions(this);
|
|
+ }
|
|
+ // Sakura end
|
|
final boolean alreadyRemoved = this.removalReason != null; // Paper - Folia schedulers
|
|
if (this.removalReason == null) {
|
|
this.removalReason = entity_removalreason;
|
|
diff --git a/src/main/java/net/minecraft/world/entity/item/FallingBlockEntity.java b/src/main/java/net/minecraft/world/entity/item/FallingBlockEntity.java
|
|
index 86e12495ce807ba06210535350caa7db5e15d139..a148befad883e5d524dcf643690f80a0bfd079e5 100644
|
|
--- a/src/main/java/net/minecraft/world/entity/item/FallingBlockEntity.java
|
|
+++ b/src/main/java/net/minecraft/world/entity/item/FallingBlockEntity.java
|
|
@@ -133,6 +133,59 @@ public class FallingBlockEntity extends Entity {
|
|
return !this.isRemoved();
|
|
}
|
|
|
|
+ // Sakura start - cannon entity merging
|
|
+ @Override
|
|
+ public boolean isMergeableType(@Nullable Entity previous) {
|
|
+ return previous == null || !isRemoved() && !previous.isRemoved();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean isSafeToMergeInto(Entity entity) {
|
|
+ return entity instanceof FallingBlockEntity fbe
|
|
+ && fbe.blockState.equals(blockState)
|
|
+ && fbe.time - 1 == time; // todo: special case in case on spawn isn't used
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ protected boolean respawnMerged() {
|
|
+ if (stacked <= 1) return false;
|
|
+
|
|
+ while (stacked-- >= 1) {
|
|
+ // Unlike PrimedTnt we have to try respawn each stacked entity
|
|
+ FallingBlockEntity fallingBlock = new FallingBlockEntity(EntityType.FALLING_BLOCK, level());
|
|
+
|
|
+ // Try to stack the falling block
|
|
+ this.entityState().apply(fallingBlock);
|
|
+ fallingBlock.spawnReason = spawnReason;
|
|
+ fallingBlock.time = time - 1;
|
|
+ fallingBlock.tick();
|
|
+
|
|
+ // If you horizontal stack into a moving piston block this condition will be met.
|
|
+ if (!fallingBlock.isRemoved()) {
|
|
+ stacked++;
|
|
+ fallingBlock.storeEntityState();
|
|
+ fallingBlock.entityState().apply(this);
|
|
+ break;
|
|
+ } else if (stacked == 0) {
|
|
+ this.discard(EntityRemoveEvent.Cause.DESPAWN);
|
|
+ }
|
|
+ }
|
|
+
|
|
+ return true;
|
|
+ }
|
|
+
|
|
+ @Nullable
|
|
+ public ItemEntity spawnAtLocation(ItemLike item) {
|
|
+ ItemEntity itemEntity = null;
|
|
+
|
|
+ while (stacked-- >= 1) {
|
|
+ itemEntity = super.spawnAtLocation(item);
|
|
+ }
|
|
+
|
|
+ return itemEntity;
|
|
+ }
|
|
+ // Sakura end
|
|
+
|
|
@Override
|
|
protected double getDefaultGravity() {
|
|
return 0.04D;
|
|
@@ -202,6 +255,7 @@ public class FallingBlockEntity extends Entity {
|
|
return;
|
|
}
|
|
// CraftBukkit end
|
|
+ if (this.respawnMerged()) return; // Sakura
|
|
if (this.level().setBlock(blockposition, this.blockState, 3)) {
|
|
((ServerLevel) this.level()).getChunkSource().chunkMap.broadcast(this, new ClientboundBlockUpdatePacket(blockposition, this.level().getBlockState(blockposition)));
|
|
this.discard(EntityRemoveEvent.Cause.DESPAWN);
|
|
diff --git a/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java b/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java
|
|
index 16340c2f8a948136c9fe0b2314c9ec7cbee74937..dc9d72bc033735dd83d7b0f3fe79d0a51b9661ab 100644
|
|
--- a/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java
|
|
+++ b/src/main/java/net/minecraft/world/entity/item/PrimedTnt.java
|
|
@@ -70,6 +70,44 @@ public class PrimedTnt extends Entity implements TraceableEntity {
|
|
return !this.isRemoved();
|
|
}
|
|
|
|
+ // Sakura start - cannon entity merging
|
|
+ @Override
|
|
+ public boolean isMergeableType(@Nullable Entity previous) {
|
|
+ return previous == null || !isRemoved() && !previous.isRemoved();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public boolean isSafeToMergeInto(Entity entity) {
|
|
+ return entity instanceof PrimedTnt tnt
|
|
+ && tnt.getFuse() + 1 == getFuse()
|
|
+ // required to prevent issues with powdered snow
|
|
+ && (tnt.entityState().fallDistance() == fallDistance
|
|
+ || tnt.entityState().fallDistance() > 2.5f && fallDistance > 2.5f);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ protected boolean respawnMerged() {
|
|
+ if (stacked <= 1) return false;
|
|
+
|
|
+ PrimedTnt tnt = new PrimedTnt(EntityType.TNT, level());
|
|
+
|
|
+ while (stacked-- > 1) {
|
|
+ this.setFuse(100); // Prevent unwanted explosions while ticking
|
|
+
|
|
+ // Cause an explosion to affect this entity
|
|
+ tnt.setPos(this.position());
|
|
+ tnt.setDeltaMovement(this.getDeltaMovement());
|
|
+ this.entityState().apply(this);
|
|
+ tnt.explode();
|
|
+ this.storeEntityState();
|
|
+
|
|
+ this.tick();
|
|
+ }
|
|
+
|
|
+ return true;
|
|
+ }
|
|
+ // Sakura end
|
|
+
|
|
@Override
|
|
protected double getDefaultGravity() {
|
|
return 0.04D;
|
|
@@ -97,6 +135,7 @@ public class PrimedTnt extends Entity implements TraceableEntity {
|
|
if (i <= 0) {
|
|
// CraftBukkit start - Need to reverse the order of the explosion and the entity death so we have a location for the event
|
|
// this.discard();
|
|
+ this.respawnMerged(); // Sakura
|
|
if (!this.level().isClientSide) {
|
|
this.explode();
|
|
}
|
|
diff --git a/src/main/java/net/minecraft/world/level/Level.java b/src/main/java/net/minecraft/world/level/Level.java
|
|
index 829a21a6da2de36f38cae9e1a3920fcc732eac0e..557472039d6451d5a8471ff56609ce49620d30df 100644
|
|
--- a/src/main/java/net/minecraft/world/level/Level.java
|
|
+++ b/src/main/java/net/minecraft/world/level/Level.java
|
|
@@ -218,6 +218,7 @@ public abstract class Level implements LevelAccessor, AutoCloseable {
|
|
public abstract ResourceKey<LevelStem> getTypeKey();
|
|
|
|
public final it.unimi.dsi.fastutil.longs.Long2IntMap minimalTNT = new it.unimi.dsi.fastutil.longs.Long2IntOpenHashMap(); // Sakura - visibility api
|
|
+ public final me.samsuik.sakura.entity.merge.MergeHistory mergeHistory = new me.samsuik.sakura.entity.merge.MergeHistory(); // Sakura - cannon entity merging
|
|
|
|
protected Level(WritableLevelData worlddatamutable, ResourceKey<Level> resourcekey, RegistryAccess iregistrycustom, Holder<DimensionType> holder, Supplier<ProfilerFiller> supplier, boolean flag, boolean flag1, long i, int j, org.bukkit.generator.ChunkGenerator gen, org.bukkit.generator.BiomeProvider biomeProvider, org.bukkit.World.Environment env, java.util.function.Function<org.spigotmc.SpigotWorldConfig, io.papermc.paper.configuration.WorldConfiguration> paperWorldConfigCreator, Supplier<me.samsuik.sakura.configuration.WorldConfiguration> sakuraWorldConfigCreator, java.util.concurrent.Executor executor) { // Sakura - sakura configuration files // Paper - create paper world config; Async-Anti-Xray: Pass executor
|
|
this.spigotConfig = new org.spigotmc.SpigotWorldConfig(((net.minecraft.world.level.storage.PrimaryLevelData) worlddatamutable).getLevelName()); // Spigot
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftFallingBlock.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftFallingBlock.java
|
|
index 1359d25a32b4a5d5e8e68ce737bd19f7b5afaf69..0afa2cfb04b5097788927076669e85fe24041df9 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftFallingBlock.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftFallingBlock.java
|
|
@@ -14,6 +14,28 @@ public class CraftFallingBlock extends CraftEntity implements FallingBlock {
|
|
super(server, entity);
|
|
}
|
|
|
|
+ // Sakura start
|
|
+ @Override
|
|
+ public @org.jetbrains.annotations.NotNull me.samsuik.sakura.entity.merge.MergeLevel getMergeLevel() {
|
|
+ return getHandle().getMergeLevel();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setMergeLevel(@org.jetbrains.annotations.NotNull me.samsuik.sakura.entity.merge.MergeLevel level) {
|
|
+ getHandle().setMergeLevel(level);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public int getStacked() {
|
|
+ return getHandle().getStacked();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setStacked(int stacked) {
|
|
+ getHandle().setStacked(stacked);
|
|
+ }
|
|
+ // Sakura end
|
|
+
|
|
@Override
|
|
public FallingBlockEntity getHandle() {
|
|
return (FallingBlockEntity) this.entity;
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftTNTPrimed.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftTNTPrimed.java
|
|
index dac3d34677688ac560bc1be2087a08479ef71b87..3e80513263236d56019e3402c52f4a3677c83c76 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftTNTPrimed.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftTNTPrimed.java
|
|
@@ -12,6 +12,28 @@ public class CraftTNTPrimed extends CraftEntity implements TNTPrimed {
|
|
super(server, entity);
|
|
}
|
|
|
|
+ // Sakura start
|
|
+ @Override
|
|
+ public @org.jetbrains.annotations.NotNull me.samsuik.sakura.entity.merge.MergeLevel getMergeLevel() {
|
|
+ return getHandle().getMergeLevel();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setMergeLevel(@org.jetbrains.annotations.NotNull me.samsuik.sakura.entity.merge.MergeLevel level) {
|
|
+ getHandle().setMergeLevel(level);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public int getStacked() {
|
|
+ return getHandle().getStacked();
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setStacked(int stacked) {
|
|
+ getHandle().setStacked(stacked);
|
|
+ }
|
|
+ // Sakura end
|
|
+
|
|
@Override
|
|
public float getYield() {
|
|
return this.getHandle().yield;
|