mirror of
https://github.com/LeavesMC/Leaves.git
synced 2025-12-23 08:59:31 +00:00
92 lines
5.2 KiB
Diff
92 lines
5.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: violetc <58360096+s-yh-china@users.noreply.github.com>
|
|
Date: Fri, 17 Mar 2023 15:57:08 +0800
|
|
Subject: [PATCH] Fix update suppression crash
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/network/protocol/PacketUtils.java b/src/main/java/net/minecraft/network/protocol/PacketUtils.java
|
|
index d2f0a0755317f5fa9a1ccf7db346aa77fd287d80..f013fb11379822c4ea307e233e30e1c293924fe1 100644
|
|
--- a/src/main/java/net/minecraft/network/protocol/PacketUtils.java
|
|
+++ b/src/main/java/net/minecraft/network/protocol/PacketUtils.java
|
|
@@ -49,6 +49,10 @@ public class PacketUtils {
|
|
co.aikar.timings.Timing timing = co.aikar.timings.MinecraftTimings.getPacketTiming(packet); // Paper - timings
|
|
try (co.aikar.timings.Timing ignored = timing.startTiming()) { // Paper - timings
|
|
packet.handle(listener);
|
|
+ // Leaves start - update suppression crash fix
|
|
+ } catch (top.leavesmc.leaves.util.UpdateSuppressionException exception) {
|
|
+ top.leavesmc.leaves.LeavesLogger.LOGGER.info("An update suppression processed");
|
|
+ // Leaves start - update suppression crash fix
|
|
} catch (Exception exception) {
|
|
if (listener.shouldPropagateHandlingExceptions()) {
|
|
throw exception;
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
index 7c90cc6ceedd4103c210757b2cc8a6ee1f972a5b..dd3a4213d978180dfc54a779253081bb34323b9e 100644
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
@@ -1551,7 +1551,13 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
|
|
|
|
try {
|
|
worldserver.timings.doTick.startTiming(); // Spigot
|
|
- worldserver.tick(shouldKeepTicking);
|
|
+ // Leaves start
|
|
+ try {
|
|
+ worldserver.tick(shouldKeepTicking);
|
|
+ } catch (top.leavesmc.leaves.util.UpdateSuppressionException e) {
|
|
+ top.leavesmc.leaves.LeavesLogger.LOGGER.info("An update suppression processed");
|
|
+ }
|
|
+ // Leaves end
|
|
// Paper start
|
|
for (final io.papermc.paper.chunk.SingleThreadChunkRegionManager regionManager : worldserver.getChunkSource().chunkMap.regionManagers) {
|
|
regionManager.recalculateRegions();
|
|
diff --git a/src/main/java/net/minecraft/world/level/redstone/NeighborUpdater.java b/src/main/java/net/minecraft/world/level/redstone/NeighborUpdater.java
|
|
index 19faa8f5f891c1ffbed0af8391dee8202433c447..0f8d5495f9f7306f3267a0741cb6a1a6d106c38e 100644
|
|
--- a/src/main/java/net/minecraft/world/level/redstone/NeighborUpdater.java
|
|
+++ b/src/main/java/net/minecraft/world/level/redstone/NeighborUpdater.java
|
|
@@ -66,9 +66,17 @@ public interface NeighborUpdater {
|
|
state.neighborChanged(world, pos, sourceBlock, sourcePos, notify);
|
|
// Spigot Start
|
|
} catch (StackOverflowError ex) {
|
|
+ // Leaves start - fix update suppression crash
|
|
+ if (top.leavesmc.leaves.LeavesConfig.updateSuppressionCrashFix) {
|
|
+ throw new top.leavesmc.leaves.util.UpdateSuppressionException();
|
|
+ }
|
|
world.lastPhysicsProblem = new BlockPos(pos);
|
|
// Spigot End
|
|
} catch (Throwable throwable) {
|
|
+ if (top.leavesmc.leaves.LeavesConfig.updateSuppressionCrashFix) {
|
|
+ throw new top.leavesmc.leaves.util.UpdateSuppressionException();
|
|
+ }
|
|
+ // Leaves end - fix update suppression crash
|
|
CrashReport crashreport = CrashReport.forThrowable(throwable, "Exception while updating neighbours");
|
|
CrashReportCategory crashreportsystemdetails = crashreport.addCategory("Block being updated");
|
|
|
|
diff --git a/src/main/java/top/leavesmc/leaves/LeavesConfig.java b/src/main/java/top/leavesmc/leaves/LeavesConfig.java
|
|
index a4a0255e537945f49398bf3bc76183c48ff47bb8..6be019bf5f50b9048f66808ef296f5c7c9b4cf14 100644
|
|
--- a/src/main/java/top/leavesmc/leaves/LeavesConfig.java
|
|
+++ b/src/main/java/top/leavesmc/leaves/LeavesConfig.java
|
|
@@ -529,6 +529,11 @@ public final class LeavesConfig {
|
|
}
|
|
}
|
|
|
|
+ public static boolean updateSuppressionCrashFix = true;
|
|
+ private static void updateSuppressionCrashFix() {
|
|
+ updateSuppressionCrashFix = getBoolean("settings.modify.fix-update-suppression-crash", updateSuppressionCrashFix);
|
|
+ }
|
|
+
|
|
public static final class WorldConfig {
|
|
|
|
public final String worldName;
|
|
diff --git a/src/main/java/top/leavesmc/leaves/util/UpdateSuppressionException.java b/src/main/java/top/leavesmc/leaves/util/UpdateSuppressionException.java
|
|
new file mode 100644
|
|
index 0000000000000000000000000000000000000000..fa4c91f4ba9a8eab4fdea97737ed778af46518dc
|
|
--- /dev/null
|
|
+++ b/src/main/java/top/leavesmc/leaves/util/UpdateSuppressionException.java
|
|
@@ -0,0 +1,7 @@
|
|
+package top.leavesmc.leaves.util;
|
|
+
|
|
+public class UpdateSuppressionException extends RuntimeException {
|
|
+ public UpdateSuppressionException() {
|
|
+ super("Update suppression");
|
|
+ }
|
|
+}
|