From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: violetc <58360096+s-yh-china@users.noreply.github.com> Date: Wed, 17 Aug 2022 11:04:12 +0800 Subject: [PATCH] Remove iterators from inventory contains This patch is Powered by Pufferfish(https://github.com/pufferfish-gg/Pufferfish) diff --git a/src/main/java/net/minecraft/world/entity/player/Inventory.java b/src/main/java/net/minecraft/world/entity/player/Inventory.java index 0e214d502998e9eb959952b257844529992df0df..9506c4cf1c757219f9f01c06cf61ad3e40ee0979 100644 --- a/src/main/java/net/minecraft/world/entity/player/Inventory.java +++ b/src/main/java/net/minecraft/world/entity/player/Inventory.java @@ -649,17 +649,31 @@ public class Inventory implements Container, Nameable { } public boolean contains(ItemStack stack) { - Iterator iterator = this.compartments.iterator(); + // Leaves start - don't allocate iterators + if (org.leavesmc.leaves.LeavesConfig.performance.remove.inventoryContainsIterators) { + for (int i = 0; i < this.compartments.size(); i++) { + List list = this.compartments.get(i); + for (int j = 0; j < list.size(); j++) { + ItemStack itemstack = list.get(j); + + if (!itemstack.isEmpty() && ItemStack.isSameItemSameComponents(itemstack, stack)) { + return true; + } + } + } + } else { + Iterator iterator = this.compartments.iterator(); - while (iterator.hasNext()) { - List list = (List) iterator.next(); - Iterator iterator1 = list.iterator(); + while (iterator.hasNext()) { + List list = (List) iterator.next(); + Iterator iterator1 = list.iterator(); - while (iterator1.hasNext()) { - ItemStack itemstack1 = (ItemStack) iterator1.next(); + while (iterator1.hasNext()) { + ItemStack itemstack1 = (ItemStack) iterator1.next(); - if (!itemstack1.isEmpty() && ItemStack.isSameItemSameComponents(itemstack1, stack)) { - return true; + if (!itemstack1.isEmpty() && ItemStack.isSameItemSameComponents(itemstack1, stack)) { + return true; + } } } } @@ -668,17 +682,30 @@ public class Inventory implements Container, Nameable { } public boolean contains(TagKey tag) { - Iterator iterator = this.compartments.iterator(); + if (org.leavesmc.leaves.LeavesConfig.performance.remove.inventoryContainsIterators) { + for (int i = 0; i < this.compartments.size(); i++) { + List list = this.compartments.get(i); + for (int j = 0; j < list.size(); j++) { + ItemStack itemstack = list.get(j); - while (iterator.hasNext()) { - List list = (List) iterator.next(); - Iterator iterator1 = list.iterator(); + if (!itemstack.isEmpty() && itemstack.is(tag)) { + return true; + } + } + } + } else { + Iterator iterator = this.compartments.iterator(); + + while (iterator.hasNext()) { + List list = (List) iterator.next(); + Iterator iterator1 = list.iterator(); - while (iterator1.hasNext()) { - ItemStack itemstack = (ItemStack) iterator1.next(); + while (iterator1.hasNext()) { + ItemStack itemstack = (ItemStack) iterator1.next(); - if (!itemstack.isEmpty() && itemstack.is(tag)) { - return true; + if (!itemstack.isEmpty() && itemstack.is(tag)) { + return true; + } } } } @@ -687,21 +714,34 @@ public class Inventory implements Container, Nameable { } public boolean contains(Predicate predicate) { - Iterator iterator = this.compartments.iterator(); + if (org.leavesmc.leaves.LeavesConfig.performance.remove.inventoryContainsIterators) { + for (int i = 0; i < this.compartments.size(); i++) { + List list = this.compartments.get(i); + for (int j = 0; j < list.size(); j++) { + ItemStack itemstack = list.get(j); - while (iterator.hasNext()) { - List list = (List) iterator.next(); - Iterator iterator1 = list.iterator(); + if (predicate.test(itemstack)) { + return true; + } + } + } + } else { + Iterator iterator = this.compartments.iterator(); - while (iterator1.hasNext()) { - ItemStack itemstack = (ItemStack) iterator1.next(); + while (iterator.hasNext()) { + List list = (List) iterator.next(); + Iterator iterator1 = list.iterator(); - if (predicate.test(itemstack)) { - return true; + while (iterator1.hasNext()) { + ItemStack itemstack = (ItemStack) iterator1.next(); + + if (predicate.test(itemstack)) { + return true; + } } } } - + // Leaves end - don't allocate iterators return false; }