fix faster chunk serial

leaves-server/src/main/java/org/leavesmc/leaves/lithium/common/world/chunk/LithiumHashPalette.java

@@ -1,14 +1,18 @@
+// Gale - Lithium - faster chunk serialization
+
 package org.leavesmc.leaves.lithium.common.world.chunk;
 
-import com.google.common.collect.ImmutableList;
 import it.unimi.dsi.fastutil.HashCommon;
-import it.unimi.dsi.fastutil.objects.Reference2IntMap;
 import it.unimi.dsi.fastutil.objects.Reference2IntOpenHashMap;
+import net.minecraft.CrashReport;
+import net.minecraft.CrashReportCategory;
+import net.minecraft.ReportedException;
 import net.minecraft.core.IdMap;
 import net.minecraft.network.FriendlyByteBuf;
 import net.minecraft.network.VarInt;
+import net.minecraft.world.level.chunk.MissingPaletteEntryException;
 import net.minecraft.world.level.chunk.Palette;
-import net.minecraft.world.level.chunk.Palette.PaletteResize;
+import net.minecraft.world.level.chunk.PaletteResize;
 import org.jetbrains.annotations.NotNull;
 
 import java.util.Arrays;
@@ -17,8 +21,6 @@ import java.util.function.Predicate;
 
 import static it.unimi.dsi.fastutil.Hash.FAST_LOAD_FACTOR;
 
-// Powered by Gale(https://github.com/GaleMC/Gale)
-
 /**
  * Generally provides better performance over the vanilla {@link net.minecraft.world.level.chunk.HashMapPalette} when calling
  * {@link LithiumHashPalette#idFor(Object)} through using a faster backing map and reducing pointer chasing.
@@ -30,11 +32,11 @@ public class LithiumHashPalette<T> implements Palette<T> {
     private final PaletteResize<T> resizeHandler;
     private final int indexBits;
 
-    private final Reference2IntMap<T> table;
+    private final Reference2IntOpenHashMap<T> table;
     private T[] entries;
     private int size = 0;
 
-    public LithiumHashPalette(IdMap<T> idList, PaletteResize<T> resizeHandler, int indexBits, T[] entries, Reference2IntMap<T> table, int size) {
+    private LithiumHashPalette(IdMap<T> idList, PaletteResize<T> resizeHandler, int indexBits, T[] entries, Reference2IntOpenHashMap<T> table, int size) {
         this.idList = idList;
         this.resizeHandler = resizeHandler;
         this.indexBits = indexBits;
@@ -43,7 +45,7 @@ public class LithiumHashPalette<T> implements Palette<T> {
         this.size = size;
     }
 
-    public LithiumHashPalette(IdMap<T> idList, int bits, PaletteResize<T> resizeHandler, @NotNull List<T> list) {
+    public LithiumHashPalette(IdMap<T> idList, int bits, PaletteResize<T> resizeHandler, List<T> list) {
         this(idList, bits, resizeHandler);
 
         for (T t : list) {
@@ -120,14 +122,32 @@ public class LithiumHashPalette<T> implements Palette<T> {
     }
 
     @Override
-    public T valueFor(int id) {
+    public @NotNull T valueFor(int id) {
         T[] entries = this.entries;
 
+        T entry = null;
         if (id >= 0 && id < entries.length) {
-            return entries[id];
+            entry = entries[id];
         }
 
-        return null;
+        if (entry != null) {
+            return entry;
+        } else {
+            throw this.missingPaletteEntryCrash(id);
+        }
+    }
+
+    private ReportedException missingPaletteEntryCrash(int id) {
+        try {
+            throw new MissingPaletteEntryException(id);
+        } catch (MissingPaletteEntryException e) {
+            CrashReport crashReport = CrashReport.forThrowable(e, "[Lithium] Getting Palette Entry");
+            CrashReportCategory crashReportCategory = crashReport.addCategory("Chunk section");
+            crashReportCategory.setDetail("IndexBits", this.indexBits);
+            crashReportCategory.setDetail("Entries", this.entries.length + " Elements: " + Arrays.toString(this.entries));
+            crashReportCategory.setDetail("Table", this.table.size() + " Elements: " + this.table);
+            return new ReportedException(crashReport);
+        }
     }
 
     @Override
@@ -137,7 +157,7 @@ public class LithiumHashPalette<T> implements Palette<T> {
         int entryCount = buf.readVarInt();
 
         for (int i = 0; i < entryCount; ++i) {
-            this.addEntry(this.idList.byId(buf.readVarInt()));
+            this.addEntry(this.idList.byIdOrThrow(buf.readVarInt()));
         }
     }
 
@@ -167,10 +187,9 @@ public class LithiumHashPalette<T> implements Palette<T> {
         return this.size;
     }
 
-    @NotNull
     @Override
-    public Palette<T> copy(@NotNull PaletteResize<T> resizeListener) {
-        return new LithiumHashPalette<>(this.idList, resizeHandler, this.indexBits, this.entries.clone(), new Reference2IntOpenHashMap<>(this.table), this.size);
+    public @NotNull Palette<T> copy(@NotNull PaletteResize<T> resizeHandler) {
+        return new LithiumHashPalette<>(this.idList, resizeHandler, this.indexBits, this.entries.clone(), this.table.clone(), this.size);
     }
 
     private void clear() {
@@ -180,17 +199,11 @@ public class LithiumHashPalette<T> implements Palette<T> {
     }
 
     public List<T> getElements() {
-        ImmutableList.Builder<T> builder = new ImmutableList.Builder<>();
-        for (T entry : this.entries) {
-            if (entry != null) {
-                builder.add(entry);
-            }
-        }
-        return builder.build();
+        T[] copy = Arrays.copyOf(this.entries, this.size);
+        return Arrays.asList(copy);
     }
 
     public static <A> Palette<A> create(int bits, IdMap<A> idList, PaletteResize<A> listener, List<A> list) {
         return new LithiumHashPalette<>(idList, bits, listener, list);
     }
-}
-
+}