mirror of
https://github.com/Winds-Studio/Leaf.git
synced 2025-12-26 18:39:23 +00:00
Originally vanilla logic is to use stream, and Mojang switched it to Guava's Collections2 since 1.21.4. It is much faster than using stream or manually adding to a new ArrayList. Manually adding to a new ArrayList requires allocating a new object array. However, the Collections2 lazy handles filter condition on iteration, so much better.
28 lines
1.3 KiB
Diff
28 lines
1.3 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: hayanesuru <hayanesuru@outlook.jp>
|
|
Date: Sat, 17 May 2025 19:03:31 +0900
|
|
Subject: [PATCH] Optimize SynchedEntityData#packDirty
|
|
|
|
|
|
diff --git a/net/minecraft/network/syncher/SynchedEntityData.java b/net/minecraft/network/syncher/SynchedEntityData.java
|
|
index f1ab0e66e7d464f7f31a7a360528ed97cdda0aa0..7ca540c70cd40815c0d4c18c2cae28a4cfd88e86 100644
|
|
--- a/net/minecraft/network/syncher/SynchedEntityData.java
|
|
+++ b/net/minecraft/network/syncher/SynchedEntityData.java
|
|
@@ -84,7 +84,15 @@ public class SynchedEntityData {
|
|
return null;
|
|
} else {
|
|
this.isDirty = false;
|
|
- List<SynchedEntityData.DataValue<?>> list = new ArrayList<>();
|
|
+ // Leaf start - Optimize SynchedEntityData#packDirty
|
|
+ int cap = 0;
|
|
+ for (SynchedEntityData.DataItem<?> dataItem : this.itemsById) {
|
|
+ if (dataItem.isDirty()) {
|
|
+ cap += 1;
|
|
+ }
|
|
+ }
|
|
+ ArrayList<SynchedEntityData.DataValue<?>> list = new ArrayList<>(cap);
|
|
+ // Leaf end - Optimize SynchedEntityData#packDirty
|
|
|
|
for (SynchedEntityData.DataItem<?> dataItem : this.itemsById) {
|
|
if (dataItem.isDirty()) {
|