9
0
mirror of https://github.com/Winds-Studio/Leaf.git synced 2025-12-28 03:19:21 +00:00
Files
Leaf/leaf-server/minecraft-patches/features/0145-Remove-stream-in-BehaviorUtils.patch
Dreeam 9a4efaa230 Drop patch that causes performance regression
Originally vanilla logic is to use stream, and Mojang switched it to Guava's Collections2
since 1.21.4. It is much faster than using stream or manually adding to a new ArrayList.
Manually adding to a new ArrayList requires allocating a new object array. However, the Collections2
lazy handles filter condition on iteration, so much better.
2025-08-04 19:25:56 +08:00

49 lines
2.2 KiB
Diff

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: HaHaWTH <102713261+HaHaWTH@users.noreply.github.com>
Date: Sat, 26 Oct 2024 00:56:24 +0800
Subject: [PATCH] Remove stream in BehaviorUtils
diff --git a/net/minecraft/world/entity/ai/behavior/BehaviorUtils.java b/net/minecraft/world/entity/ai/behavior/BehaviorUtils.java
index cc8f0586fca7b12a95afadb08d51077c74713ce3..ceddfed85cedbe2ddaea9ef6530688b69f087874 100644
--- a/net/minecraft/world/entity/ai/behavior/BehaviorUtils.java
+++ b/net/minecraft/world/entity/ai/behavior/BehaviorUtils.java
@@ -112,10 +112,33 @@ public class BehaviorUtils {
public static SectionPos findSectionClosestToVillage(ServerLevel serverLevel, SectionPos sectionPos, int radius) {
int i = serverLevel.sectionsToVillage(sectionPos);
- return SectionPos.cube(sectionPos, radius)
- .filter(pos -> serverLevel.sectionsToVillage(pos) < i)
- .min(Comparator.comparingInt(serverLevel::sectionsToVillage))
- .orElse(sectionPos);
+ // Leaf start - Remove stream in BehaviorUtils
+ SectionPos closestSection = sectionPos;
+ int closestDistance = i;
+
+ final int lowerX = sectionPos.getX() - radius;
+ final int lowerY = sectionPos.getY() - radius;
+ final int lowerZ = sectionPos.getZ() - radius;
+ final int upperX = sectionPos.getX() + radius;
+ final int upperY = sectionPos.getY() + radius;
+ final int upperZ = sectionPos.getZ() + radius;
+
+ for (int x = lowerX; x <= upperX; x++) {
+ for (int z = lowerZ; z <= upperZ; z++) {
+ for (int y = lowerY; y <= upperY; y++) {
+ SectionPos pos = SectionPos.of(x, y, z);
+ int distance = serverLevel.sectionsToVillage(pos);
+
+ if (distance < closestDistance) {
+ closestDistance = distance;
+ closestSection = pos;
+ }
+ }
+ }
+ }
+
+ return closestSection;
+ // Leaf end - Remove stream in BehaviorUtils
}
public static boolean isWithinAttackRange(Mob mob, LivingEntity target, int cooldown) {