From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Taiyou06 Date: Sat, 22 Mar 2025 00:07:38 +0100 Subject: [PATCH] Optimize addOrUpdateTransientModifier diff --git a/net/minecraft/world/entity/ai/attributes/AttributeInstance.java b/net/minecraft/world/entity/ai/attributes/AttributeInstance.java index b502c4a0f3695cc5bee8954f937f64584df1584d..26d97742310c054eebbee7f4dc2f535d3ee4cd2e 100644 --- a/net/minecraft/world/entity/ai/attributes/AttributeInstance.java +++ b/net/minecraft/world/entity/ai/attributes/AttributeInstance.java @@ -107,8 +107,13 @@ public class AttributeInstance { } public void addOrUpdateTransientModifier(AttributeModifier modifier) { - AttributeModifier attributeModifier = this.modifierById.put(modifier.id(), modifier); - if (modifier != attributeModifier) { + // Leaf start - Optimize addOrUpdateTransientModifier + // First check if we already have the same modifier instance to avoid unnecessary put operations + AttributeModifier existingModifier = this.modifierById.get(modifier.id()); + // Only perform updates if the modifier is new or different + if (existingModifier != modifier) { + this.modifierById.put(modifier.id(), modifier); + // Leaf end - Optimize addOrUpdateTransientModifier this.getModifiers(modifier.operation()).put(modifier.id(), modifier); this.setDirty(); }