From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Bjarne Koll Date: Thu, 9 Dec 2021 01:53:30 +0100 Subject: [PATCH] KTP: Optimize Spigot event bus Original license: GPL v3 Original project: https://github.com/lynxplay/ktp diff --git a/src/main/java/org/bukkit/plugin/RegisteredListener.java b/src/main/java/org/bukkit/plugin/RegisteredListener.java index 3b3d9642a8d63798dc28f2f8df77f0466451cbff..8d3605f25e97a375971705c737bc7bacbac045cd 100644 --- a/src/main/java/org/bukkit/plugin/RegisteredListener.java +++ b/src/main/java/org/bukkit/plugin/RegisteredListener.java @@ -62,8 +62,10 @@ public class RegisteredListener { * @throws EventException If an event handler throws an exception. */ public void callEvent(@NotNull final Event event) throws EventException { - if (event instanceof Cancellable) { - if (((Cancellable) event).isCancelled() && isIgnoringCancelled()) { + // KTP start - optimize spigot event bus + if (isIgnoringCancelled()) { + if (event instanceof Cancellable cancellable && cancellable.isCancelled()) { + // KTP end - optimize spigot event bus return; } } diff --git a/src/main/java/org/bukkit/plugin/SimplePluginManager.java b/src/main/java/org/bukkit/plugin/SimplePluginManager.java index 623c683563a5fb5dcf3b8478873ef2a27307b289..e7e7a4b5ed1a1ae7b4f711daec51003514908d86 100644 --- a/src/main/java/org/bukkit/plugin/SimplePluginManager.java +++ b/src/main/java/org/bukkit/plugin/SimplePluginManager.java @@ -640,11 +640,15 @@ public final class SimplePluginManager implements PluginManager { // Gale end - JettPack - skip events without listeners // Paper - replace callEvent by merging to below method - if (event.isAsynchronous() && server.isPrimaryThread()) { + // KTP start - optimize spigot event bus + final boolean isAsync = event.isAsynchronous(); + final boolean isPrimary = server.isPrimaryThread(); // Cache to prevent multiple thread object comparisons. + if (isAsync && isPrimary) { throw new IllegalStateException(event.getEventName() + " may only be triggered asynchronously."); - } else if (!event.isAsynchronous() && !server.isPrimaryThread() && !server.isStopping() ) { + } else if (!isAsync && !isPrimary && !server.isStopping() ) { throw new IllegalStateException(event.getEventName() + " may only be triggered synchronously."); } + // KTP end - optimize spigot event bus for (RegisteredListener registration : listeners) { if (!registration.getPlugin().isEnabled()) {