From 4b1921b75453951d18f9d1fbbe82e7cd3928ca6d Mon Sep 17 00:00:00 2001 From: Craftinators Date: Mon, 27 Feb 2023 22:55:12 -0500 Subject: [PATCH] clean: `try-with-resource` to `SuppressWarnings` --- .../hmccosmetics/database/types/MySQLData.java | 3 ++- .../hibiscusmc/hmccosmetics/database/types/SQLData.java | 9 ++++++--- .../hmccosmetics/database/types/SQLiteData.java | 4 +++- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/MySQLData.java b/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/MySQLData.java index 9298f931..329c6339 100644 --- a/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/MySQLData.java +++ b/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/MySQLData.java @@ -55,7 +55,8 @@ public class MySQLData extends SQLData { @Override public void clear(UUID uniqueId) { Bukkit.getScheduler().runTaskAsynchronously(HMCCosmeticsPlugin.getInstance(), () -> { - try (PreparedStatement preparedSt = preparedStatement("DELETE FROM COSMETICDATABASE WHERE UUID=?;")) { + try { + PreparedStatement preparedSt = preparedStatement("DELETE FROM COSMETICDATABASE WHERE UUID=?;"); preparedSt.setString(1, uniqueId.toString()); preparedSt.executeUpdate(); } catch (SQLException e) { diff --git a/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLData.java b/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLData.java index 78713e9d..2372ca64 100644 --- a/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLData.java +++ b/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLData.java @@ -15,12 +15,13 @@ import java.util.UUID; public abstract class SQLData extends Data { @Override - @SuppressWarnings("Duplicates") // Duplicate is from deprecated InternalData + @SuppressWarnings({"Duplicates", "resource"}) // Duplicate is from deprecated InternalData public CosmeticUser get(UUID uniqueId) { CosmeticUser user = new CosmeticUser(uniqueId); Bukkit.getScheduler().runTaskAsynchronously(HMCCosmeticsPlugin.getInstance(), () -> { - try (PreparedStatement preparedStatement = preparedStatement("SELECT * FROM COSMETICDATABASE WHERE UUID = ?;")) { + try { + PreparedStatement preparedStatement = preparedStatement("SELECT * FROM COSMETICDATABASE WHERE UUID = ?;"); preparedStatement.setString(1, uniqueId.toString()); ResultSet rs = preparedStatement.executeQuery(); if (rs.next()) { @@ -44,9 +45,11 @@ public abstract class SQLData extends Data { } @Override + @SuppressWarnings("resource") public void save(CosmeticUser user) { Runnable run = () -> { - try (PreparedStatement preparedSt = preparedStatement("REPLACE INTO COSMETICDATABASE(UUID,COSMETICS) VALUES(?,?);")) { + try { + PreparedStatement preparedSt = preparedStatement("REPLACE INTO COSMETICDATABASE(UUID,COSMETICS) VALUES(?,?);"); preparedSt.setString(1, user.getUniqueId().toString()); preparedSt.setString(2, serializeData(user)); preparedSt.executeUpdate(); diff --git a/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLiteData.java b/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLiteData.java index f7801c25..0a606a54 100644 --- a/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLiteData.java +++ b/common/src/main/java/com/hibiscusmc/hmccosmetics/database/types/SQLiteData.java @@ -42,9 +42,11 @@ public class SQLiteData extends SQLData { } @Override + @SuppressWarnings("resource") public void clear(UUID uniqueId) { Bukkit.getScheduler().runTaskAsynchronously(HMCCosmeticsPlugin.getInstance(), () -> { - try (PreparedStatement preparedSt = preparedStatement("DELETE FROM COSMETICDATABASE WHERE UUID=?;")) { + try { + PreparedStatement preparedSt = preparedStatement("DELETE FROM COSMETICDATABASE WHERE UUID=?;"); preparedSt.setString(1, uniqueId.toString()); preparedSt.executeUpdate(); } catch (SQLException e) {