From 461642d64b4172c4843c203f95e1a9f50b0df86b Mon Sep 17 00:00:00 2001 From: Craftinators Date: Wed, 1 Mar 2023 00:44:00 -0500 Subject: [PATCH] clean: make `Type` abstract --- .../com/hibiscusmc/hmccosmetics/gui/type/Type.java | 12 ++++-------- .../hmccosmetics/gui/type/types/TypeEmpty.java | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/Type.java b/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/Type.java index 59a4e56f..ef8d7b74 100644 --- a/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/Type.java +++ b/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/Type.java @@ -5,7 +5,7 @@ import org.bukkit.event.inventory.ClickType; import org.bukkit.inventory.meta.ItemMeta; import org.spongepowered.configurate.ConfigurationNode; -public class Type { +public abstract class Type { private final String id; @@ -21,12 +21,8 @@ public class Type { public void run(CosmeticUser user, ConfigurationNode config) { run(user, config, null); } - public void run(CosmeticUser user, ConfigurationNode config, ClickType clickType) { - // Override - } - public ItemMeta setLore(CosmeticUser user, ConfigurationNode config, ItemMeta itemMeta) { - //TODO: Finish this - return null; // Override - } + public abstract void run(CosmeticUser user, ConfigurationNode config, ClickType clickType); + + public abstract ItemMeta setLore(CosmeticUser user, ConfigurationNode config, ItemMeta itemMeta); } diff --git a/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/types/TypeEmpty.java b/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/types/TypeEmpty.java index a5f53331..1fc88fd1 100644 --- a/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/types/TypeEmpty.java +++ b/common/src/main/java/com/hibiscusmc/hmccosmetics/gui/type/types/TypeEmpty.java @@ -18,7 +18,6 @@ import java.util.List; public class TypeEmpty extends Type { // This can be used as an example for making your own types. - public TypeEmpty() { super("empty"); // This is an empty type, meaning, when a menu item has a type of "empty" it will run the code in the method run.