libreforge-updater

FIX: Prevent to give expirience to task when it marked as completed

eco-core/core-plugin/src/main/kotlin/com/willfp/ecoquests/quests/Quest.kt

@@ -101,12 +101,22 @@ class Quest(
 
     // The tasks that are actually in use
     var tasks = run {
+        if (taskAmount == availableTasks.size) {
+            // If taskAmount is equal to availableTasks.size then tasks are ordered as configured
+            if (isResettable) {
+                availableTasks.take(taskAmount)
+            } else {
+                availableTasks.shuffled().take(taskAmount)
+            }
+        } else {
+            // If taskAmount is less than availableTasks.size then tasks are selected and ordered randomly.
             if (isResettable) {
                 loadTasks() ?: availableTasks.randomlyPick(taskAmount)
             } else {
                 availableTasks.randomlyPick(taskAmount)
             }
         }
+    }
         private set
 
     private val hasStartedKey = PersistentDataKey(
@@ -268,7 +278,8 @@ class Quest(
     }
 
     fun getDescription(player: Player): List<String> {
-        return addPlaceholdersInto(listOf(config.getString("description")), player)
+        val descriptions = config.getStrings("description")
+        return addPlaceholdersInto(descriptions, player)
     }
 
     fun hasActive(player: OfflinePlayer): Boolean {

eco-core/core-plugin/src/main/kotlin/com/willfp/ecoquests/tasks/Task.kt

@@ -146,6 +146,11 @@ class Task(
      * Give experience directly
      */
     fun giveExperience(player: Player, amount: Double) {
+
+        if (player.profile.read(hasCompletedKey)) {
+            return
+        }
+
         val requiredXp = getExperienceRequired(player)
         val newXp = player.profile.read(xpKey) + amount
 

gradle.properties

@@ -1,5 +1,5 @@
 #libreforge-updater
-#Thu Aug 15 15:07:42 BST 2024
+#Wed Nov 06 18:33:27 GMT 2024
 kotlin.code.style=official
-libreforge-version=4.71.1
+libreforge-version=4.72.2
-version=1.42.1
+version=1.43.2