From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: NONPLAYT <76615486+NONPLAYT@users.noreply.github.com> Date: Fri, 31 Jan 2025 21:50:46 +0300 Subject: [PATCH] Misc Optimizations diff --git a/com/mojang/math/OctahedralGroup.java b/com/mojang/math/OctahedralGroup.java index 11902e7427761746ee098fea3276a34fef0096ba..3ba23fa243f7af712a41316066ca554f1c23b495 100644 --- a/com/mojang/math/OctahedralGroup.java +++ b/com/mojang/math/OctahedralGroup.java @@ -112,6 +112,7 @@ public enum OctahedralGroup implements StringRepresentable { this.transformation = new Matrix3f().scaling(invertX ? -1.0F : 1.0F, invertY ? -1.0F : 1.0F, invertZ ? -1.0F : 1.0F); this.transformation.mul(permutation.transformation()); this.initializeRotationDirections(); // Paper - Avoid Lazy Initialization for Enum Fields + this.rotate(Direction.UP); // DivineMC - Math Optimizations } private BooleanList packInversions() { diff --git a/com/mojang/math/Transformation.java b/com/mojang/math/Transformation.java index aa755b8b7f8bc5910322e0c5b520f603da06a85a..e781dea43279aa77cc40a7afd2281c32cc8347a9 100644 --- a/com/mojang/math/Transformation.java +++ b/com/mojang/math/Transformation.java @@ -51,6 +51,7 @@ public final class Transformation { } else { this.matrix = matrix; } + ensureDecomposed(); // DivineMC - Math Optimizations } public Transformation(@Nullable Vector3f translation, @Nullable Quaternionf leftRotation, @Nullable Vector3f scale, @Nullable Quaternionf rightRotation) { @@ -60,6 +61,7 @@ public final class Transformation { this.scale = scale != null ? scale : new Vector3f(1.0F, 1.0F, 1.0F); this.rightRotation = rightRotation != null ? rightRotation : new Quaternionf(); this.decomposed = true; + ensureDecomposed(); // DivineMC - Math Optimizations } public static Transformation identity() { diff --git a/net/minecraft/core/MappedRegistry.java b/net/minecraft/core/MappedRegistry.java index 5f752603aa5611ce9d3dd44cc5b70c27ac46a86e..332122c0b700fb743f91f3fed16aade41dceec28 100644 --- a/net/minecraft/core/MappedRegistry.java +++ b/net/minecraft/core/MappedRegistry.java @@ -34,10 +34,12 @@ public class MappedRegistry implements WritableRegistry { private final ResourceKey> key; private final ObjectList> byId = new ObjectArrayList<>(256); private final Reference2IntMap toId = Util.make(new Reference2IntOpenHashMap<>(2048), map -> map.defaultReturnValue(-1)); // Paper - Perf: Use bigger expected size to reduce collisions - private final Map> byLocation = new HashMap<>(2048); // Paper - Perf: Use bigger expected size to reduce collisions - private final Map, Holder.Reference> byKey = new HashMap<>(2048); // Paper - Perf: Use bigger expected size to reduce collisions - private final Map> byValue = new IdentityHashMap<>(2048); // Paper - Perf: Use bigger expected size to reduce collisions - private final Map, RegistrationInfo> registrationInfos = new IdentityHashMap<>(2048); // Paper - Perf: Use bigger expected size to reduce collisions + // DivineMC start - Some optimizations + private final Map> byLocation = new java.util.concurrent.ConcurrentHashMap<>(2048); // Paper - Perf: Use bigger expected size to reduce collisions + private final Map, Holder.Reference> byKey = new java.util.concurrent.ConcurrentHashMap<>(2048); // Paper - Perf: Use bigger expected size to reduce collisions + private final Map> byValue = Collections.synchronizedMap(new IdentityHashMap<>(2048)); // Paper - Perf: Use bigger expected size to reduce collisions + private final Map, RegistrationInfo> registrationInfos = Collections.synchronizedMap(new IdentityHashMap<>(2048)); // Paper - Perf: Use bigger expected size to reduce collisions + // DivineMC end - Some optimizations private Lifecycle registryLifecycle; private final Map, HolderSet.Named> frozenTags = new IdentityHashMap<>(); MappedRegistry.TagSet allTags = MappedRegistry.TagSet.unbound(); diff --git a/net/minecraft/server/level/ChunkTrackingView.java b/net/minecraft/server/level/ChunkTrackingView.java index bee90335677f7d8b01589ce5cfd81a40fd422886..a5e488d14fd2016ee188b114d0e681562b5b09cc 100644 --- a/net/minecraft/server/level/ChunkTrackingView.java +++ b/net/minecraft/server/level/ChunkTrackingView.java @@ -73,12 +73,12 @@ public interface ChunkTrackingView { } static boolean isWithinDistance(int centerX, int centerZ, int viewDistance, int x, int z, boolean includeOuterChunksAdjacentToViewBorder) { - int i = includeOuterChunksAdjacentToViewBorder ? 2 : 1; - long l = Math.max(0, Math.abs(x - centerX) - i); - long l1 = Math.max(0, Math.abs(z - centerZ) - i); - long l2 = l * l + l1 * l1; - int i1 = viewDistance * viewDistance; - return l2 < i1; + // DivineMC start - Some optimizations + int actualViewDistance = viewDistance + (includeOuterChunksAdjacentToViewBorder ? 1 : 0); + int xDistance = Math.abs(centerX - x); + int zDistance = Math.abs(centerZ - z); + return xDistance <= actualViewDistance && zDistance <= actualViewDistance; + // DivineMC end - Some optimizations } public record Positioned(ChunkPos center, int viewDistance) implements ChunkTrackingView { diff --git a/net/minecraft/util/ClassInstanceMultiMap.java b/net/minecraft/util/ClassInstanceMultiMap.java index 2a708ae0d5bb209650b525e3c56051f8b5655074..4c7670224f0c90c1d0d833ff0b3d908846133b4a 100644 --- a/net/minecraft/util/ClassInstanceMultiMap.java +++ b/net/minecraft/util/ClassInstanceMultiMap.java @@ -14,9 +14,9 @@ import java.util.Map.Entry; import net.minecraft.Util; public class ClassInstanceMultiMap extends AbstractCollection { - private final Map, List> byClass = Maps.newHashMap(); + private final Map, List> byClass = new it.unimi.dsi.fastutil.objects.Object2ObjectLinkedOpenHashMap<>(); // DivineMC - Misc Optimizations private final Class baseClass; - private final List allInstances = Lists.newArrayList(); + private final List allInstances = new it.unimi.dsi.fastutil.objects.ObjectArrayList<>(); // DivineMC - Misc Optimizations public ClassInstanceMultiMap(Class baseClass) { this.baseClass = baseClass; @@ -56,13 +56,27 @@ public class ClassInstanceMultiMap extends AbstractCollection { } public Collection find(Class type) { + // DivineMC start - Some optimizations + List cached = this.byClass.get(type); + if (cached != null) return (Collection) cached; + if (!this.baseClass.isAssignableFrom(type)) { throw new IllegalArgumentException("Don't know how to search for " + type); } else { - List list = this.byClass - .computeIfAbsent(type, clazz -> this.allInstances.stream().filter(clazz::isInstance).collect(Util.toMutableList())); - return (Collection)Collections.unmodifiableCollection(list); + List list = this.byClass.computeIfAbsent(type, + typeClass -> { + it.unimi.dsi.fastutil.objects.ObjectArrayList ts = new it.unimi.dsi.fastutil.objects.ObjectArrayList<>(this.allInstances.size()); + for (Object _allElement : ((it.unimi.dsi.fastutil.objects.ObjectArrayList) this.allInstances).elements()) { + if (typeClass.isInstance(_allElement)) { + ts.add((T) _allElement); + } + } + return ts; + } + ); + return (Collection) list; } + // DivineMC end - Some optimizations } @Override diff --git a/net/minecraft/util/CrudeIncrementalIntIdentityHashBiMap.java b/net/minecraft/util/CrudeIncrementalIntIdentityHashBiMap.java index f28fbf81a417a678726d3f77b3999054676d522e..7ff32b1f93b31fafd13f4e0857d14d85ef1f28c7 100644 --- a/net/minecraft/util/CrudeIncrementalIntIdentityHashBiMap.java +++ b/net/minecraft/util/CrudeIncrementalIntIdentityHashBiMap.java @@ -52,23 +52,23 @@ public class CrudeIncrementalIntIdentityHashBiMap implements IdMap, ca.spo @Nullable @Override - public K byId(int value) { + public synchronized K byId(int value) { // DivineMC - Misc Optimizations return value >= 0 && value < this.byId.length ? this.byId[value] : null; } - private int getValue(int key) { + private synchronized int getValue(int key) { // DivineMC - Misc Optimizations return key == -1 ? -1 : this.values[key]; } - public boolean contains(K value) { + public synchronized boolean contains(K value) { // DivineMC - Misc Optimizations return this.getId(value) != -1; } - public boolean contains(int value) { + public synchronized boolean contains(int value) { // DivineMC - Misc Optimizations return this.byId(value) != null; } - public int add(K object) { + public synchronized int add(K object) { // DivineMC - Misc Optimizations int i = this.nextId(); this.addMapping(object, i); return i; @@ -106,7 +106,7 @@ public class CrudeIncrementalIntIdentityHashBiMap implements IdMap, ca.spo // Paper end - optimise palette reads } - public void addMapping(K object, int intKey) { + public synchronized void addMapping(K object, int intKey) { // DivineMC - Misc Optimizations int max = Math.max(intKey, this.size + 1); if (max >= this.keys.length * 0.8F) { int i = this.keys.length << 1; @@ -173,11 +173,11 @@ public class CrudeIncrementalIntIdentityHashBiMap implements IdMap, ca.spo } @Override - public Iterator iterator() { + public synchronized Iterator iterator() { // DivineMC - Misc Optimizations return Iterators.filter(Iterators.forArray(this.byId), Predicates.notNull()); } - public void clear() { + public synchronized void clear() { // DivineMC - Misc Optimizations Arrays.fill(this.keys, null); Arrays.fill(this.byId, null); this.nextId = 0; diff --git a/net/minecraft/util/CubicSpline.java b/net/minecraft/util/CubicSpline.java index f36f8f2d49d4eba5c80eb243883749d6f831eb8a..5abd899c88683cb79bb8f02e43c4bfbe8563f496 100644 --- a/net/minecraft/util/CubicSpline.java +++ b/net/minecraft/util/CubicSpline.java @@ -254,31 +254,47 @@ public interface CubicSpline> extends ToFloatFun @Override public float apply(C object) { - float f = this.coordinate.apply(object); - int i = findIntervalStart(this.locations, f); - int i1 = this.locations.length - 1; - if (i < 0) { - return linearExtend(f, this.locations, this.values.get(0).apply(object), this.derivatives, 0); - } else if (i == i1) { - return linearExtend(f, this.locations, this.values.get(i1).apply(object), this.derivatives, i1); + // DivineMC start - Some optimizations + float point = this.coordinate.apply(object); + int rangeForLocation = findIntervalStart(this.locations, point); + int last = this.locations.length - 1; + if (rangeForLocation < 0) { + return linearExtend(point, this.locations, this.values.get(0).apply(object), this.derivatives, 0); + } else if (rangeForLocation == last) { + return linearExtend(point, this.locations, this.values.get(last).apply(object), this.derivatives, last); } else { - float f1 = this.locations[i]; - float f2 = this.locations[i + 1]; - float f3 = (f - f1) / (f2 - f1); - ToFloatFunction toFloatFunction = (ToFloatFunction)this.values.get(i); - ToFloatFunction toFloatFunction1 = (ToFloatFunction)this.values.get(i + 1); - float f4 = this.derivatives[i]; - float f5 = this.derivatives[i + 1]; - float f6 = toFloatFunction.apply(object); - float f7 = toFloatFunction1.apply(object); - float f8 = f4 * (f2 - f1) - (f7 - f6); - float f9 = -f5 * (f2 - f1) + (f7 - f6); - return Mth.lerp(f3, f6, f7) + f3 * (1.0F - f3) * Mth.lerp(f3, f8, f9); + float loc0 = this.locations[rangeForLocation]; + float loc1 = this.locations[rangeForLocation + 1]; + float locDist = loc1 - loc0; + float k = (point - loc0) / locDist; + float n = this.values.get(rangeForLocation).apply(object); + float o = this.values.get(rangeForLocation + 1).apply(object); + float onDist = o - n; + float p = this.derivatives[rangeForLocation] * locDist - onDist; + float q = -this.derivatives[rangeForLocation + 1] * locDist + onDist; + return Mth.lerp(k, n, o) + k * (1.0F - k) * Mth.lerp(k, p, q); } + // DivineMC end - Some optimizations } private static int findIntervalStart(float[] locations, float start) { - return Mth.binarySearch(0, locations.length, i -> start < locations[i]) - 1; + // DivineMC start - Some optimizations + int min = 0; + int i = locations.length; + + while (i > 0) { + int j = i / 2; + int k = min + j; + if (start < locations[k]) { + i = j; + } else { + min = k + 1; + i -= j + 1; + } + } + + return min - 1; + // DivineMC end - Some optimizations } @VisibleForTesting @@ -313,5 +329,27 @@ public interface CubicSpline> extends ToFloatFun this.derivatives ); } + + // DivineMC start - Some optimizations + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + Multipoint that = (Multipoint) o; + return java.util.Objects.equals(coordinate, that.coordinate()) && java.util.Arrays.equals(locations, that.locations()) && java.util.Objects.equals(values, that.values()) && java.util.Arrays.equals(derivatives, that.derivatives()); + } + + @Override + public int hashCode() { + int result = 1; + + result = 31 * result + java.util.Objects.hashCode(coordinate); + result = 31 * result + java.util.Arrays.hashCode(locations); + result = 31 * result + java.util.Objects.hashCode(values); + result = 31 * result + java.util.Arrays.hashCode(derivatives); + + return result; + } + // DivineMC end - Some optimizations } } diff --git a/net/minecraft/util/Mth.java b/net/minecraft/util/Mth.java index ab3a221c115992d0f4ea921aa92cf0976b815ff4..076a931341da486162f289a5f19d3d6736df7768 100644 --- a/net/minecraft/util/Mth.java +++ b/net/minecraft/util/Mth.java @@ -46,11 +46,11 @@ public class Mth { private static final double[] COS_TAB = new double[257]; public static float sin(float value) { - return SIN[(int)(value * 10430.378F) & 65535]; + return net.caffeinemc.mods.lithium.common.util.math.CompactSineLUT.sin(value); // DivineMC - Math Optimizations } public static float cos(float value) { - return SIN[(int)(value * 10430.378F + 16384.0F) & 65535]; + return net.caffeinemc.mods.lithium.common.util.math.CompactSineLUT.cos(value); // DivineMC - Math Optimizations } public static float sqrt(float value) { @@ -58,18 +58,15 @@ public class Mth { } public static int floor(float value) { - int i = (int)value; - return value < i ? i - 1 : i; + return (int) Math.floor(value); // DivineMC - Math Optimizations } public static int floor(double value) { - int i = (int)value; - return value < i ? i - 1 : i; + return (int) Math.floor(value); // DivineMC - Math Optimizations } public static long lfloor(double value) { - long l = (long)value; - return value < l ? l - 1L : l; + return (long) Math.floor(value); // DivineMC - Math Optimizations } public static float abs(float value) { @@ -81,13 +78,11 @@ public class Mth { } public static int ceil(float value) { - int i = (int)value; - return value > i ? i + 1 : i; + return (int) Math.ceil(value); // DivineMC - Math Optimizations } public static int ceil(double value) { - int i = (int)value; - return value > i ? i + 1 : i; + return (int) Math.ceil(value); // DivineMC - Math Optimizations } public static int clamp(int value, int min, int max) { @@ -123,15 +118,7 @@ public class Mth { } public static double absMax(double x, double y) { - if (x < 0.0) { - x = -x; - } - - if (y < 0.0) { - y = -y; - } - - return Math.max(x, y); + return Math.max(Math.abs(x), Math.abs(y)); // DivineMC - Math Optimizations } public static int floorDiv(int dividend, int divisor) { @@ -162,14 +149,26 @@ public class Mth { return Math.floorMod(x, y); } - public static float positiveModulo(float numerator, float denominator) { + public static float positiveModuloForAnyDenominator(float numerator, float denominator) { // DivineMC - Math Optimizations return (numerator % denominator + denominator) % denominator; } - public static double positiveModulo(double numerator, double denominator) { + public static double positiveModuloForAnyDenominator(double numerator, double denominator) { // DivineMC - Math Optimizations return (numerator % denominator + denominator) % denominator; } + // DivineMC start - Math Optimizations + public static float positiveModuloForPositiveIntegerDenominator(float numerator, float denominator) { + var modulo = numerator % denominator; + return modulo < 0 ? modulo + denominator : modulo; + } + + public static double positiveModuloForPositiveIntegerDenominator(double numerator, double denominator) { + var modulo = numerator % denominator; + return modulo < 0 ? modulo + denominator : modulo; + } + // DivineMC end - Math Optimizations + public static boolean isMultipleOf(int number, int multiple) { return number % multiple == 0; } diff --git a/net/minecraft/util/RandomSource.java b/net/minecraft/util/RandomSource.java index 98a54bc4de251014342cda6d0951b7fea79ce553..663edee4dfa660e3d3a04c728fd764258867916d 100644 --- a/net/minecraft/util/RandomSource.java +++ b/net/minecraft/util/RandomSource.java @@ -12,7 +12,7 @@ public interface RandomSource { double GAUSSIAN_SPREAD_FACTOR = 2.297; static RandomSource create() { - return create(RandomSupport.generateUniqueSeed()); + return createThreadSafe(); // DivineMC - Misc Optimizations } @Deprecated @@ -21,7 +21,7 @@ public interface RandomSource { } static RandomSource create(long seed) { - return new LegacyRandomSource(seed); + return new ThreadSafeLegacyRandomSource(seed); // DivineMC - Misc Optimizations } static RandomSource createNewThreadLocalInstance() { diff --git a/net/minecraft/util/debugchart/DebugSampleSubscriptionTracker.java b/net/minecraft/util/debugchart/DebugSampleSubscriptionTracker.java index 15de39fa82c7aea18298509fe9587d027c30cc15..eb534ed5a7478fc632db096328e3582f4ec410b8 100644 --- a/net/minecraft/util/debugchart/DebugSampleSubscriptionTracker.java +++ b/net/minecraft/util/debugchart/DebugSampleSubscriptionTracker.java @@ -15,7 +15,7 @@ public class DebugSampleSubscriptionTracker { public static final int STOP_SENDING_AFTER_MS = 10000; private final PlayerList playerList; private final EnumMap> subscriptions; - private final Queue subscriptionRequestQueue = new LinkedList<>(); + private final java.util.List subscriptionRequestQueue = java.util.Collections.synchronizedList(new LinkedList<>()); // DivineMC - Misc Optimizations public DebugSampleSubscriptionTracker(PlayerList playerList) { this.playerList = playerList; diff --git a/net/minecraft/world/entity/Entity.java b/net/minecraft/world/entity/Entity.java index 7e29f1f1972f2fb4f9a779653467bc85ce37c7bc..3943789e241f6bb6bc165099b1fb585463cf3d86 100644 --- a/net/minecraft/world/entity/Entity.java +++ b/net/minecraft/world/entity/Entity.java @@ -143,7 +143,7 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess } // Paper start - Share random for entities to make them more random - public static RandomSource SHARED_RANDOM = new RandomRandomSource(); + public static RandomSource SHARED_RANDOM = new net.minecraft.world.level.levelgen.ThreadSafeLegacyRandomSource(net.minecraft.world.level.levelgen.RandomSupport.generateUniqueSeed()); // DivineMC - Misc Optimizations // Paper start - replace random private static final class RandomRandomSource extends ca.spottedleaf.moonrise.common.util.ThreadUnsafeRandom { public RandomRandomSource() { diff --git a/net/minecraft/world/entity/Mob.java b/net/minecraft/world/entity/Mob.java index 66f3565b978f2ed91cb2bc3a816f1701c0873c73..b4e19cc65701d5ef94e1cc0a7473225c222725c3 100644 --- a/net/minecraft/world/entity/Mob.java +++ b/net/minecraft/world/entity/Mob.java @@ -832,7 +832,7 @@ public abstract class Mob extends LivingEntity implements EquipmentUser, Leashab if (this.level().getDifficulty() == Difficulty.PEACEFUL && this.shouldDespawnInPeaceful()) { this.discard(EntityRemoveEvent.Cause.DESPAWN); // CraftBukkit - add Bukkit remove cause } else if (!this.isPersistenceRequired() && !this.requiresCustomPersistence()) { - Entity nearestPlayer = this.level().findNearbyPlayer(this, -1.0, EntitySelector.PLAYER_AFFECTS_SPAWNING); // Paper - Affects Spawning API + Entity nearestPlayer = this.divinemc$findNearbyPlayer(this.level(), this, -1.0); // Paper - Affects Spawning API // DivineMC - faster player lookup if (nearestPlayer != null) { // Paper start - Configurable despawn distances final io.papermc.paper.configuration.WorldConfiguration.Entities.Spawning.DespawnRangePair despawnRangePair = this.level().paperConfig().entities.spawning.despawnRanges.get(this.getType().getCategory()); @@ -861,6 +861,19 @@ public abstract class Mob extends LivingEntity implements EquipmentUser, Leashab } } + // DivineMC start - faster player lookup + private Player divinemc$findNearbyPlayer(Level instance, Entity entity, double maxDistance) { + final Player closestPlayer = instance.getNearestPlayer(entity, this.getType().getCategory().getDespawnDistance()); + if (closestPlayer != null) { + return closestPlayer; + } else { + final List players = this.level().players(); + if (players.isEmpty()) return null; + return players.get(0); + } + } + // DivineMC end - faster player lookup + @Override protected final void serverAiStep() { this.noActionTime++; diff --git a/net/minecraft/world/level/GameRules.java b/net/minecraft/world/level/GameRules.java index 5ded2f808a9fcb26856567de6bc56e206f948a84..02d64a5ea756b2c91a71b7a0fc0f21219983616a 100644 --- a/net/minecraft/world/level/GameRules.java +++ b/net/minecraft/world/level/GameRules.java @@ -249,7 +249,7 @@ public class GameRules { } private GameRules(Map, GameRules.Value> rules, FeatureFlagSet enabledFeatures) { - this.rules = rules; + this.rules = new it.unimi.dsi.fastutil.objects.Object2ObjectOpenHashMap<>(rules); // DivineMC - lithium: collections.gamerules this.enabledFeatures = enabledFeatures; // Paper start - Perf: Use array for gamerule storage diff --git a/net/minecraft/world/level/LocalMobCapCalculator.java b/net/minecraft/world/level/LocalMobCapCalculator.java index 9641219c190261dea0db5f95f040a705ba0a3ff9..a3fccdeb2c076e12b611683da55d45e00a166417 100644 --- a/net/minecraft/world/level/LocalMobCapCalculator.java +++ b/net/minecraft/world/level/LocalMobCapCalculator.java @@ -13,16 +13,24 @@ import net.minecraft.world.entity.MobCategory; public class LocalMobCapCalculator { private final Long2ObjectMap> playersNearChunk = new Long2ObjectOpenHashMap<>(); - private final Map playerMobCounts = Maps.newHashMap(); + private final Map playerMobCounts = Maps.newConcurrentMap(); // DivineMC - Misc Optimizations private final ChunkMap chunkMap; public LocalMobCapCalculator(ChunkMap chunkMap) { this.chunkMap = chunkMap; } - private List getPlayersNear(ChunkPos pos) { - return this.playersNearChunk.computeIfAbsent(pos.toLong(), key -> this.chunkMap.getPlayersCloseForSpawning(pos)); + // DivineMC start - Some optimizations + private synchronized @org.jetbrains.annotations.NotNull List getPlayersNear(ChunkPos pos) { + List retVal = this.playersNearChunk.get(pos.toLong()); + if (retVal == null) { + List newVal = this.chunkMap.getPlayersCloseForSpawning(pos); + this.playersNearChunk.put(pos.toLong(), newVal); + return newVal; + } + return retVal; } + // DivineMC end - Some optimizations public void addMob(ChunkPos pos, MobCategory category) { for (ServerPlayer serverPlayer : this.getPlayersNear(pos)) { @@ -42,14 +50,14 @@ public class LocalMobCapCalculator { } static class MobCounts { - private final Object2IntMap counts = new Object2IntOpenHashMap<>(MobCategory.values().length); + private final int[] spawnGroupDensities = new int[MobCategory.values().length]; // DivineMC - Misc Optimizations public void add(MobCategory category) { - this.counts.computeInt(category, (key, value) -> value == null ? 1 : value + 1); + this.spawnGroupDensities[category.ordinal()] ++; // DivineMC - Misc Optimizations } public boolean canSpawn(MobCategory category) { - return this.counts.getOrDefault(category, 0) < category.getMaxInstancesPerChunk(); + return this.spawnGroupDensities[category.ordinal()] < category.getMaxInstancesPerChunk(); // DivineMC - Misc Optimizations } } } diff --git a/net/minecraft/world/level/levelgen/blending/Blender.java b/net/minecraft/world/level/levelgen/blending/Blender.java index 01e5b29d6e9a5c53c0e23b61ed0c1d7be1a0fe08..d80df05e40f3941ade5ed320e12f8dcf47e6b247 100644 --- a/net/minecraft/world/level/levelgen/blending/Blender.java +++ b/net/minecraft/world/level/levelgen/blending/Blender.java @@ -144,7 +144,7 @@ public class Blender { private static double heightToOffset(double height) { double d = 1.0; double d1 = height + 0.5; - double d2 = Mth.positiveModulo(d1, 8.0); + double d2 = Mth.positiveModuloForPositiveIntegerDenominator(d1, 8.0); // DivineMC - Math optimizations return 1.0 * (32.0 * (d1 - 128.0) - 3.0 * (d1 - 120.0) * d2 + 3.0 * d2 * d2) / (128.0 * (32.0 - 3.0 * d2)); } diff --git a/net/minecraft/world/level/saveddata/maps/MapItemSavedData.java b/net/minecraft/world/level/saveddata/maps/MapItemSavedData.java index 3d6aad86519be3e1449d3288369a41aebb924c90..9294ac7bb91f86b631b1f0b4ad0bc1dbca82b3a1 100644 --- a/net/minecraft/world/level/saveddata/maps/MapItemSavedData.java +++ b/net/minecraft/world/level/saveddata/maps/MapItemSavedData.java @@ -198,6 +198,7 @@ public class MapItemSavedData extends SavedData { } } + mapItemSavedData.setDirty(false); // DivineMC - Misc Optimizations return mapItemSavedData; } diff --git a/net/minecraft/world/level/storage/DimensionDataStorage.java b/net/minecraft/world/level/storage/DimensionDataStorage.java index d9a3b5a2e6495b7e22c114506c2bd1e406f58f8f..a6e03345afd6d8a38e06a43c59103209618baa14 100644 --- a/net/minecraft/world/level/storage/DimensionDataStorage.java +++ b/net/minecraft/world/level/storage/DimensionDataStorage.java @@ -34,7 +34,7 @@ import org.slf4j.Logger; public class DimensionDataStorage implements AutoCloseable { private static final Logger LOGGER = LogUtils.getLogger(); - public final Map> cache = new HashMap<>(); + public final Map> cache = new java.util.concurrent.ConcurrentHashMap<>(); // DivineMC - Concurrent HashMap private final DataFixer fixerUpper; private final HolderLookup.Provider registries; private final Path dataFolder; diff --git a/net/minecraft/world/phys/AABB.java b/net/minecraft/world/phys/AABB.java index c9c6e4e460ad8435f12761704bb9b0284d6aa708..54807bb4b4189ceaded1f78a1a9ab85ce40ab2b1 100644 --- a/net/minecraft/world/phys/AABB.java +++ b/net/minecraft/world/phys/AABB.java @@ -189,13 +189,15 @@ public class AABB { } public AABB intersect(AABB other) { - double max = Math.max(this.minX, other.minX); - double max1 = Math.max(this.minY, other.minY); - double max2 = Math.max(this.minZ, other.minZ); - double min = Math.min(this.maxX, other.maxX); - double min1 = Math.min(this.maxY, other.maxY); - double min2 = Math.min(this.maxZ, other.maxZ); - return new AABB(max, max1, max2, min, min1, min2); + // DivineMC start - Math Optimizations + return new AABB( + this.minX > other.minX ? this.minX : other.minX, + this.minY > other.minY ? this.minY : other.minY, + this.minZ > other.minZ ? this.minZ : other.minZ, + this.maxX < other.maxX ? this.maxX : other.maxX, + this.maxY < other.maxY ? this.maxY : other.maxY, + this.maxZ < other.maxZ ? this.maxZ : other.maxZ + ); } public AABB minmax(AABB other) { @@ -227,16 +229,37 @@ public class AABB { } public boolean intersects(AABB other) { - return this.intersects(other.minX, other.minY, other.minZ, other.maxX, other.maxY, other.maxZ); + // DivineMC start - Math Optimizations + return this.minX < other.maxX && + this.maxX > other.minX && + this.minY < other.maxY && + this.maxY > other.minY && + this.minZ < other.maxZ && + this.maxZ > other.minZ; + // DivineMC end - Math Optimizations } public boolean intersects(double x1, double y1, double z1, double x2, double y2, double z2) { - return this.minX < x2 && this.maxX > x1 && this.minY < y2 && this.maxY > y1 && this.minZ < z2 && this.maxZ > z1; + // DivineMC start - Math Optimizations + return this.minX < x2 && + this.maxX > x1 && + this.minY < y2 && + this.maxY > y1 && + this.minZ < z2 && + this.maxZ > z1; + // DivineMC end - Math Optimizations } public boolean intersects(Vec3 min, Vec3 max) { return this.intersects( - Math.min(min.x, max.x), Math.min(min.y, max.y), Math.min(min.z, max.z), Math.max(min.x, max.x), Math.max(min.y, max.y), Math.max(min.z, max.z) + // DivineMC start - Math Optimizations + min.x < max.x ? min.x : max.x, + min.y < max.y ? min.y : max.y, + min.z < max.z ? min.z : max.z, + min.x > max.x ? min.x : max.x, + min.y > max.y ? min.y : max.y, + min.z > max.z ? min.z : max.z + // DivineMC end - Math Optimizations ); }