GeyserMC-Mirror/Geyser
1
0
Fork 0
mirror of https://github.com/GeyserMC/Geyser.git synced 2026-01-06 15:41:50 +00:00
Code Issues Releases Activity

Merchant changes, implement splash_potion entity type, some xp orb fixes

Browse Source
This commit is contained in:
onebeastchris
2025-03-28 21:16:03 +01:00
parent a7502a6b3a
commit dbf701feb1
9 changed files with 19 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
core/src/test/java/org/geysermc/geyser/scoreboard/network/ScoreboardIssueTests.java
View File

@@ -70,34 +70,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
* Tests for issues reported on GitHub.
*/
public class ScoreboardIssueTests {
// TODO 1.21.5
// /**
// * Test for <a href="https://github.com/GeyserMC/Geyser/issues/5075">#5075</a>
// */
// @Test
// void entityWithoutUuid() {
// // experience orbs are the only known entities without an uuid, see Entity#teamIdentifier for more info
// mockContextScoreboard(context -> {
// var addExperienceOrbTranslator = new JavaAddExperienceOrbTranslator();
// var removeEntitiesTranslator = new JavaRemoveEntitiesTranslator();
//
// // Entity#teamIdentifier used to throw because it returned uuid.toString where uuid could be null.
// // this would result in both EntityCache#spawnEntity and EntityCache#removeEntity throwing an exception,
// // because the entity would be registered and deregistered to the scoreboard.
// assertDoesNotThrow(() -> {
// context.translate(addExperienceOrbTranslator, new ClientboundAddExperienceOrbPacket(2, 0, 0, 0, 1));
//
// String displayName = context.mockOrSpy(EntityCache.class).getEntityByJavaId(2).getDisplayName();
// assertEquals("entity.minecraft.experience_orb", displayName);
//
// context.translate(removeEntitiesTranslator, new ClientboundRemoveEntitiesPacket(new int[] { 2 }));
// });
//
// // we know that spawning and removing the entity should be fine
// assertNextPacketType(context, AddEntityPacket.class);
// assertNextPacketType(context, RemoveEntityPacket.class);
// });
// }
/**
* Test for <a href="https://github.com/GeyserMC/Geyser/issues/5078">#5078</a>